Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

126 vs l16 for operating_system - lowercase L vs number 1 #863

Closed
TheBelgarion opened this issue Jan 7, 2024 · 3 comments
Closed

126 vs l16 for operating_system - lowercase L vs number 1 #863

TheBelgarion opened this issue Jan 7, 2024 · 3 comments
Labels
✨ enhancement New feature or request stale

Comments

@TheBelgarion
Copy link

Error: expected type to be one of ["l24" "l26" "other" "solaris" "w2k" "w2k3" "w2k8" "win7" "win8" "win10" "win11" "wvista" "wxp"], got 126

│ with proxmox_virtual_environment_vm.test,
│ on test.tf line 64, in resource "proxmox_virtual_environment_vm" "test":
│ 64: type = "126"

It took me quite some time to figure out its not "126" but "l26"

l16

on my putty terminal is was not as visible as it is here (guess should select another font anyway)

maybe is should be upper case L26 and WIN7 ... and do an internal conversion lowertoupper to be backward compatible with old terraform?

@bpg bpg added the ✨ enhancement New feature or request label Jan 7, 2024
@bpg
Copy link
Owner

bpg commented Jan 7, 2024

Thanks, seems reasonable :)

@TheBelgarion
Copy link
Author

i just saw that the values are from proxmox QM so not sure if that will accept uppercase there as well - if not maybe just a notice in the docu section ;-) so noone else falls for the same trap :-)

@bpg-autobot
Copy link
Contributor

bpg-autobot bot commented Jul 6, 2024

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@bpg-autobot bpg-autobot bot added the stale label Jul 6, 2024
@bpg-autobot bpg-autobot bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants