Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosuggest: Close expression after applying a suggested variable #378

Closed
pinussilvestrus opened this issue Oct 2, 2020 · 3 comments
Closed
Labels
0.x Issues created for 0.x series. enhancement New feature or request wontfix This will not be worked on

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Oct 2, 2020

Is your feature request related to a problem? Please describe

We offer auto-suggesting of available process variables when creating expressions in input mappings. One feature we offer on top is that we also suggesting those items if the user starts typing an expression (${), without closing bracket.

Kapture 2020-10-02 at 13 20 21

However, after the variable got applied to the input, the expression is not valid in this case due to the missing closing bracket. The user would have to add it afterward on his own.

It would be nice if we could support the user by automatically adding this.

Describe the solution you'd like

Add closing bracket (}) after a suggestion item got applied, in case (and only in case) the user is typing inside an unclosed expression. The cursor should be still on the position after the inserted item.

Describe alternatives you've considered

  • Adding a warning hint, if the expression is unclosed (?)
  • We could also make this completely independent to the auto-suggesting, and simply add the closing bracket once a starting clause was typed (without the action of auto-suggesting). We should handle this issue when talking about the JUEL expression code editor in the next steps.
@pinussilvestrus pinussilvestrus added the enhancement New feature or request label Oct 2, 2020
@andreasgeier
Copy link

I would not combine a variable suggestion overlay with auto-addding closing brackets. Where is the relation? I would see this as part of the effort the replace simple textareas with a code editor view where we can think about such typical features like adding a closing bracket when you type in the opening bracket etc.

@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Oct 2, 2020
@pinussilvestrus
Copy link
Contributor Author

Valid point @andreasgeier, I added this to the alternatives. We will then see, how to deal with that.

@barmac barmac added the 0.x Issues created for 0.x series. label Nov 29, 2021
@barmac
Copy link
Member

barmac commented Apr 13, 2022

I am closing this as wontfix because we released a complete rewrite of the properties panel as v1.0.0. Please feel free to reopen this issue if the problem persists in the 1.x series.

@barmac barmac closed this as completed Apr 13, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Apr 13, 2022
@barmac barmac added the wontfix This will not be worked on label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.x Issues created for 0.x series. enhancement New feature or request wontfix This will not be worked on
Development

No branches or pull requests

3 participants