Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'create' opinion cannot removed in palette entries #2165

Closed
okankrdg opened this issue May 22, 2024 · 1 comment
Closed

'create' opinion cannot removed in palette entries #2165

okankrdg opened this issue May 22, 2024 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@okankrdg
Copy link

okankrdg commented May 22, 2024

Describe the Bug

'create' cannot remove from palette entries and mot filtering

Screenshot_74

Steps to Reproduce

  1. do this
export function CustomPaletteProvider(palette) {
  palette.registerProvider(this);
}

CustomPaletteProvider.$inject = ['palette'];

CustomPaletteProvider.prototype.getPaletteEntries = function (element) {
  return function (entries) {
    console.log('entries', entries);
    delete entries['create'];
    return entries;
  };
};

export default {
  __init__: ['customPalette'],
  customPalette: ['type', CustomPaletteProvider],
};
  1. do that
    'create' anything opinion still see in palette but if you remove other opinion like hand-tool, correctly works.

Expected Behavior

'create' must be removed in palette entries

Environment

  • Browser: edge 125
  • Library version: latest
@okankrdg okankrdg added the bug Something isn't working label May 22, 2024
@nikku
Copy link
Member

nikku commented May 22, 2024

@okankrdg Create/append anything is not part of the core since v12.0.0. Closing this request as invalid.

If you report bugs, be precise, establish the necessary context and we'll be able to help you.

@nikku nikku closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@nikku nikku added the invalid This doesn't seem right label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Development

No branches or pull requests

2 participants