Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRD overview in DMN decision table view shows empty diagram #572

Open
MaxTru opened this issue Aug 24, 2020 · 4 comments
Open

DRD overview in DMN decision table view shows empty diagram #572

MaxTru opened this issue Aug 24, 2020 · 4 comments
Labels
backlog Queued in backlog bug Something isn't working

Comments

@MaxTru
Copy link
Contributor

MaxTru commented Aug 24, 2020

Describe the Bug

In the constellation of this bug, the DRD overview in the DMN decision table view shows an empty diagram (although a decision exists).

The bug appeared when following the DMN getting started guide in step "DRG": https://docs.camunda.org/get-started/dmn/drg/.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Download the get-started resources from step 3, unpack them
  2. open the file src/main/resources/dinnerDecisions.dmn
  3. DRD overview shows empty diagram

BugMissingOverview

When manipulating the DRD (e.g., by adding another decision), the issue does not occur anymore.

Expected Behavior

DRD overview is shown

Environment

Please complete the following information:

  • Camunda Modeler 4.2.1
  • OS: Arch Linux Manjaro
@MaxTru MaxTru added the bug Something isn't working label Aug 24, 2020
@barmac
Copy link
Member

barmac commented Aug 24, 2020

The diagram does not contain DMNDI which so the DrdViewer import in the overlay fails. However, we swallow the error in https://github.com/camunda/camunda-modeler/blob/4728c3cd55cb0f2873040d5c1186c5c9794597a0/client/src/app/tabs/dmn/modeler/DmnModeler.js#L276 as there is no active viewer. The diagram can be opened in dmn-js Modeler only due to DiGenerator module which is not included in the viewer.

@barmac
Copy link
Member

barmac commented Aug 24, 2020

What we could do is to include the DiGenerator in either dmn-js viewer or the viewer used in DmnModeler overlay.

@barmac
Copy link
Member

barmac commented Aug 24, 2020

And definitely we should add DMNDI to the Getting Started DMN.

@MaxTru
Copy link
Contributor Author

MaxTru commented Aug 24, 2020

Thanks for the analysis.

I will update the Getting Started DMN with the DMNDI.

Including the DIGenerator in the dmn-js viewer would certainly make the Modeler more robust. However, this is not a priority item.

@MaxTru MaxTru added the backlog Queued in backlog label Aug 24, 2020 — with bpmn-io-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working
Development

No branches or pull requests

2 participants