Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListGroup flashes with unsorted content when re-opened and needs to sort #107

Closed
barmac opened this issue Oct 8, 2021 · 3 comments
Closed
Labels
a11y bug Something isn't working

Comments

@barmac
Copy link
Member

barmac commented Oct 8, 2021

Describe the Bug

When I create multiple elements in a list group, it flashes with unsorted content when I re-open.

aa.mp4

Steps to Reproduce

  1. Create multiple elements
  2. Name them from [c, b, a] to force sorting
  3. Close and open

Expected Behavior

No flash. It should be sorted right away

@barmac barmac added bug Something isn't working a11y labels Oct 8, 2021
@barmac barmac changed the title ListGroup flashes when re-opened and needs to sort ListGroup flashes with unsorted content when re-opened and needs to sort Oct 8, 2021
@barmac
Copy link
Member Author

barmac commented Oct 8, 2021

This could probably be solved if we synchronously sort before the render is flushed to the DOM. Check how it was done in the nested list. Alternatively, we could try out useLayoutEffect.

@nikku nikku added the backlog Queued in backlog label Oct 13, 2021 — with bpmn-io-tasks
@smbea
Copy link
Contributor

smbea commented Apr 11, 2022

I can't reproduce this. It appears sorted when re-opening. Maybe we fixed this along the way?

@barmac
Copy link
Member Author

barmac commented Apr 11, 2022

Let's close it then.

@barmac barmac closed this as completed Apr 11, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y bug Something isn't working
Development

No branches or pull requests

3 participants