Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser default monospace font is used for text areas #87

Closed
pinussilvestrus opened this issue Aug 3, 2021 · 0 comments · Fixed by #88
Closed

Browser default monospace font is used for text areas #87

pinussilvestrus opened this issue Aug 3, 2021 · 0 comments · Fixed by #88
Assignees
@pinussilvestrus
Labels
bug Something isn't working

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Aug 3, 2021 •
edited
Loading

Describe the Bug

When using the TextArea component, the default monospace font is used.

image

Steps to Reproduce

  1. Create text area entry
  2. See monospace font defined

image

Expected Behavior

monospace should not be set as default. We have edge cases in https://github.com/bpmn-io/bpmn-properties-panel where text areas might need this font (e.g. for scripts, cf. bpmn-io/bpmn-properties-panel#49 (review)). For this cases it should be configurable.

Environment

  • Host (Browser/Node version), if applicable: Chrome 92
  • OS: macOS 11.5
  • Library version: main
@pinussilvestrus pinussilvestrus added the bug Something isn't working label Aug 3, 2021
@pinussilvestrus pinussilvestrus mentioned this issue Aug 3, 2021
Merged
pinussilvestrus pushed a commit that referenced this issue Aug 3, 2021
feat(text-area): make monospace font optional
7e6f1eb 
Closes #87
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 3, 2021
@pinussilvestrus pinussilvestrus mentioned this issue Aug 3, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 3, 2021
pinussilvestrus pushed a commit to bpmn-io/bpmn-properties-panel that referenced this issue Aug 3, 2021
feat(script-props): set monospace
a207e4b 
Related to bpmn-io/properties-panel#87
@pinussilvestrus pinussilvestrus mentioned this issue Aug 3, 2021
Merged
@fake-join fake-join bot closed this as completed in #88 Aug 3, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 3, 2021
fake-join bot pushed a commit that referenced this issue Aug 3, 2021
@fake-join
feat(text-area): make monospace font optional
f51741a 
Closes #87
pinussilvestrus pushed a commit to bpmn-io/bpmn-properties-panel that referenced this issue Aug 3, 2021
feat(script-props): set monospace
5fba840 
Related to bpmn-io/properties-panel#87
fake-join bot pushed a commit to bpmn-io/bpmn-properties-panel that referenced this issue Aug 4, 2021
@fake-join
feat(script-props): set monospace
1274321 
Related to bpmn-io/properties-panel#87
marstamm pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jun 8, 2023
@fake-join
feat(script-props): set monospace
39348ed 
Related to bpmn-io/properties-panel#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(text-area): make monospace font optional bpmn-io/properties-panel
1 participant
@pinussilvestrus