Deprecate Task, use a Promise-based approach. v2.0.0 proposal #15

minuscorp · 2019-09-17T10:54:21Z

This PR deprecates a Task-based approach in favor of a more widespread architecture based in Promises see this for more information about the topic.

This highly simplifies the modeling of how the States are defined, being converted into promises with their fulfilled or rejected inner state and Swift.Result value with the final representation of the Promise.

sebastianvarela · 2019-09-17T11:14:25Z

	1 Error
🚫	Failed due to SwiftLint errors

	1 Warning
⚠️	Big PR, try to keep changes smaller if you can 😜

SwiftLint found issues

Warnings

File	Line	Reason
DispatcherTests.swift	48	Types should be nested at most 1 level deep (nesting)
PromiseTests.swift	54	An XCTFail call should include a description of the assertion. (xctfail_message)
PromiseTests.swift	71	An XCTFail call should include a description of the assertion. (xctfail_message)
ObservableTypeTests.swift	15	Variable name should be between 3 and 40 characters long: 'by' (identifier_name)
ObservableTypeTests.swift	34	Method 'setUp()' should call to super function (overridden_super_call)
PrimitiveSequenceTypeTests.swift	10	Variable name should be between 3 and 40 characters long: 'by' (identifier_name)
PrimitiveSequenceTypeTests.swift	29	Types should be nested at most 1 level deep (nesting)
PrimitiveSequenceTypeTests.swift	44	Types should be nested at most 1 level deep (nesting)
PrimitiveSequenceTypeTests.swift	45	Types should be nested at most 1 level deep (nesting)
ChainTests.swift	6	Types should be nested at most 1 level deep (nesting)

Errors

File	Line	Reason
ReducerTests.swift	19	Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift	50	Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift	73	Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift	102	Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift	128	Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
XCTestManifests.swift	8	Variable name should only contain alphanumeric characters: '__allTests__ChainTests' (identifier_name)
XCTestManifests.swift	17	Variable name should only contain alphanumeric characters: '__allTests__DictionaryExtensionsTests' (identifier_name)
XCTestManifests.swift	27	Variable name should only contain alphanumeric characters: '__allTests__DispatchQueueTests' (identifier_name)
XCTestManifests.swift	36	Variable name should only contain alphanumeric characters: '__allTests__DispatcherTests' (identifier_name)
XCTestManifests.swift	47	Variable name should only contain alphanumeric characters: '__allTests__ObservableTypeTests' (identifier_name)
XCTestManifests.swift	58	Variable name should only contain alphanumeric characters: '__allTests__PrimitiveSequenceTypeTests' (identifier_name)
XCTestManifests.swift	71	Variable name should only contain alphanumeric characters: '__allTests__PromiseTests' (identifier_name)
XCTestManifests.swift	90	Variable name should only contain alphanumeric characters: '__allTests__ReducerTests' (identifier_name)
XCTestManifests.swift	100	Function name should start with a lowercase character: '__allTests()' (identifier_name)
ChainTests.swift	29	Force casts should be avoided. (force_cast)

Generated by 🚫 Danger

codecov · 2019-09-17T12:50:40Z

Codecov Report

Merging #15 into master will increase coverage by 29.54%.
The diff coverage is 82.67%.

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
+ Coverage   51.98%   81.53%   +29.54%     
===========================================
  Files          18       16        -2     
  Lines         504      601       +97     
===========================================
+ Hits          262      490      +228     
+ Misses        242      111      -131

Flag	Coverage Δ
#ios	`81.53% <82.67%> (+29.54%)`	⬆️
#mac	`?`
#osx	`81.53% <82.67%> (?)`
#tv	`?`
#tvos	`81.53% <82.67%> (?)`

Impacted Files	Coverage Δ
Sources/Mini/StateType.swift	`0% <ø> (ø)`
Sources/Mini/Utils/PayloadAction.swift	`0% <0%> (ø)`
Sources/Mini/Utils/SharedDictionary.swift	`60% <100%> (ø)`
Sources/Mini/Dispatcher.swift	`89.81% <100%> (ø)`
Sources/Mini/ActionReducer.swift	`100% <100%> (ø)`
Sources/Mini/ReducerGroup.swift	`100% <100%> (ø)`
Sources/Mini/Utils/OrderedSet.swift	`68.18% <100%> (ø)`
...ni/Utils/Foundation/DispatchQueue+Extensions.swift	`100% <100%> (ø)`
Sources/Mini/Middleware.swift	`100% <100%> (ø)`
Sources/Mini/Store.swift	`80% <55.55%> (ø)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea19c8...46b8481. Read the comment docs.

hound · 2019-09-23T15:24:40Z

Package.swift

@@ -29,7 +30,7 @@ let package = Package(
            dependencies: ["RxSwift", "NIOConcurrencyHelpers"]),
        .testTarget(
            name: "MiniSwiftTests",
-            dependencies: ["MiniSwift", "RxSwift"]),
+            dependencies: ["MiniSwift", "NIOConcurrencyHelpers", "RxSwift", "Nimble", "RxTest", "RxBlocking"]),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-27T08:50:06Z

Sources/MiniSwift/Promise.swift

+        self.box.seal(.failure(error))
+        return self
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-09-30T13:20:09Z

Scripts/update_docs.rb

+interface = JSON.parse(response)
+
+# Write just the interface all to a file, in theory we can make a HTML version of this in the future
+File.write("Documentation/Reference/Mini.swift", interface["key.sourcetext"])


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-09-30T13:20:10Z

Scripts/update_docs.rb

+
+interface = JSON.parse(response)
+
+# Write just the interface all to a file, in theory we can make a HTML version of this in the future


Metrics/LineLength: Line is too long. [100/80]

hound · 2019-09-30T13:20:10Z

Scripts/update_docs.rb

+         .gsub("[CWD]", Dir.pwd)
+         .gsub("[TMP_DIR]", tmp_dir)
+
+File.write("Scripts/data/request.yml", file)


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-09-30T13:20:10Z

Scripts/update_docs.rb

+         .gsub("[DEBUG_ROOT]", debug_dir)
+         .gsub("[SDK_ROOT]", sdk_dir)
+         .gsub("[CWD]", Dir.pwd)
+         .gsub("[TMP_DIR]", tmp_dir)


Layout/MultilineMethodCallIndentation: Align .gsub with template on line 16.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-09-30T13:20:10Z

Scripts/update_docs.rb

+file = template
+         .gsub("[DEBUG_ROOT]", debug_dir)
+         .gsub("[SDK_ROOT]", sdk_dir)
+         .gsub("[CWD]", Dir.pwd)


Layout/MultilineMethodCallIndentation: Align .gsub with template on line 16.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-09-30T13:20:12Z

Scripts/update_docs.rb

@@ -0,0 +1,33 @@
+#!/usr/bin/env ruby


Lint/ScriptPermission: Script file update_docs.rb doesn't have execute permission.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

hound · 2019-09-30T13:20:12Z

Rakefile

@@ -27,3 +27,8 @@ end
 task(:test) do
  sh('swift test')
 end
+
+task(:docs) do
+  sh('swift run sourcedocs generate --spm-module MiniSwift --output-folder Documentation/reference')


Metrics/LineLength: Line is too long. [100/80]

hound · 2019-09-30T13:20:12Z

Package.swift

+                "rake docs",
+                "Scripts/update_changelog.sh",
+            ],
+        ],


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T13:20:13Z

Package.swift

+            "before": [
+                "rake docs",
+                "Scripts/update_changelog.sh",
+            ],


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T13:20:13Z

Package.swift

+        "rocket": [
+            "before": [
+                "rake docs",
+                "Scripts/update_changelog.sh",


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T13:40:41Z

Package.swift

+        .package(url: "https://github.com/nicklockwood/SwiftFormat", from: "0.35.8"), // dev
+        .package(url: "https://github.com/shibapm/Rocket", from: "0.4.0"), // dev
+        .package(url: "https://github.com/Realm/SwiftLint", from: "0.28.1"), // dev
+        .package(url: "https://github.com/eneko/SourceDocs", from: "0.5.1"), // dev


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T13:40:41Z

Documentation/reference/Mini.swift

+extension PrimitiveSequenceType where Self: RxSwift.ObservableConvertibleType, Self.Trait == RxSwift.SingleTrait {
+    public func dispatch<A>(action: A.Type, on dispatcher: MiniSwift.Dispatcher, mode: MiniSwift.Dispatcher.DispatchMode.UI = .async, fillOnError errorPayload: A.Payload? = nil) -> RxSwift.Disposable where A: MiniSwift.CompletableAction, Self.Element == A.Payload
+
+    public func dispatch<A>(action: A.Type, key: A.Key, on dispatcher: MiniSwift.Dispatcher, mode: MiniSwift.Dispatcher.DispatchMode.UI = .async, fillOnError errorPayload: A.Payload? = nil) -> RxSwift.Disposable where A: MiniSwift.KeyedCompletableAction, Self.Element == A.Payload


Line Length Violation: Line should be 250 characters or less: currently 280 characters (line_length)

hound · 2019-09-30T13:40:41Z

Documentation/reference/Mini.swift

+}
+
+extension PrimitiveSequenceType where Self: RxSwift.ObservableConvertibleType, Self.Trait == RxSwift.SingleTrait {
+    public func dispatch<A>(action: A.Type, on dispatcher: MiniSwift.Dispatcher, mode: MiniSwift.Dispatcher.DispatchMode.UI = .async, fillOnError errorPayload: A.Payload? = nil) -> RxSwift.Disposable where A: MiniSwift.CompletableAction, Self.Element == A.Payload


Line Length Violation: Line should be 250 characters or less: currently 263 characters (line_length)

hound · 2019-09-30T13:40:41Z

Documentation/reference/Mini.swift

+extension ObservableType where Self.Element: MiniSwift.StoreType, Self.Element: RxSwift.ObservableType, Self.Element.Element == Self.Element.State {
+    public static func dispatch<A, Type, T>(using dispatcher: MiniSwift.Dispatcher, factory action: @autoclosure @escaping () -> A, taskMap: @escaping (Self.Element.State) -> T?, on store: Self.Element, lifetime: MiniSwift.Promises.Lifetime = .once) -> RxSwift.Observable<Self.Element.State> where A: MiniSwift.Action, T: MiniSwift.Promise<Type>
+
+    public static func dispatch<A, K, Type, T>(using dispatcher: MiniSwift.Dispatcher, factory action: @autoclosure @escaping () -> A, key: K, taskMap: @escaping (Self.Element.State) -> [K: T], on store: Self.Element, lifetime: MiniSwift.Promises.Lifetime = .once) -> RxSwift.Observable<Self.Element.State> where A: MiniSwift.Action, K: Hashable, T: MiniSwift.Promise<Type>


Line Length Violation: Line should be 250 characters or less: currently 373 characters (line_length)

hound · 2019-09-30T13:40:41Z

Documentation/reference/Mini.swift

+}
+
+extension ObservableType where Self.Element: MiniSwift.StoreType, Self.Element: RxSwift.ObservableType, Self.Element.Element == Self.Element.State {
+    public static func dispatch<A, Type, T>(using dispatcher: MiniSwift.Dispatcher, factory action: @autoclosure @escaping () -> A, taskMap: @escaping (Self.Element.State) -> T?, on store: Self.Element, lifetime: MiniSwift.Promises.Lifetime = .once) -> RxSwift.Observable<Self.Element.State> where A: MiniSwift.Action, T: MiniSwift.Promise<Type>


Line Length Violation: Line should be 250 characters or less: currently 345 characters (line_length)

hound · 2019-09-30T13:40:42Z

Documentation/reference/Mini.swift

+
+    public subscript(_: Key, orPut _: @autoclosure () -> Value) -> Value { get }
+
+    public subscript(_: Key) -> Value? { get }


Implicit Getter Violation: Computed read-only subscripts should avoid using the get keyword. (implicit_getter)

hound · 2019-09-30T13:40:42Z

Documentation/reference/Mini.swift

+
+    public func get(withKey key: Key) -> Value?
+
+    public subscript(_: Key, orPut _: @autoclosure () -> Value) -> Value { get }


Implicit Getter Violation: Computed read-only subscripts should avoid using the get keyword. (implicit_getter)

hound · 2019-09-30T13:40:43Z

Documentation/reference/Mini.swift

+    init(promise: MiniSwift.Promise<Self.Payload?>)
+}
+
+@dynamicMemberLookup public final class Promise<T>: MiniSwift.PromiseType {


Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports. (attributes)

hound · 2019-09-30T13:40:43Z

Documentation/reference/Mini.swift

+
+    /// Returns the item at the given index.
+    /// Assertion fails if the index is out of the range of [0, count).
+    public subscript(_: Int) -> T { get }


Implicit Getter Violation: Computed read-only subscripts should avoid using the get keyword. (implicit_getter)

hound · 2019-09-30T13:40:43Z

Documentation/reference/Mini.swift

+
+public final class Dispatcher {
+    public struct DispatchMode {
+        public enum UI {


Nesting Violation: Types should be nested at most 1 level deep (nesting)
Type Name Violation: Type name should be between 3 and 40 characters long: 'UI' (type_name)

hound · 2019-09-30T14:36:25Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        ("test_reset_state", test_reset_state),
+        ("test_state_received_in_store", test_state_received_in_store),
+        ("test_subscribe_to_store_receive_actions", test_subscribe_to_store_receive_actions),
+        ("test_subscribe_to_store_receive_multiple_actions", test_subscribe_to_store_receive_multiple_actions),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T14:36:25Z

Tests/MiniSwiftTests/XCTestManifests.swift

-        ("test_success_task_with_expiration_setted", test_success_task_with_expiration_setted),
-        ("test_success_task_with_expiration_setted_to_immediately", test_success_task_with_expiration_setted_to_immediately)
+    static let __allTests__ReducerTests = [
+        ("test_dispatcher_triggers_action_in_reducer_group_reducer", test_dispatcher_triggers_action_in_reducer_group_reducer),


Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)

hound · 2019-09-30T14:36:26Z

Tests/MiniSwiftTests/XCTestManifests.swift

-        ("test_expiration_of_task_created_with_past_date", test_expiration_of_task_created_with_past_date),
-        ("test_success_task_with_expiration_setted", test_success_task_with_expiration_setted),
-        ("test_success_task_with_expiration_setted_to_immediately", test_success_task_with_expiration_setted_to_immediately)
+    static let __allTests__ReducerTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__ReducerTests' (identifier_name)

hound · 2019-09-30T14:36:26Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        ("test_is_rejected", test_is_rejected),
+        ("test_is_resolved", test_is_resolved),
+        ("test_promise_properties", test_promise_properties),
+        ("test_reject", test_reject),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T14:36:26Z

Tests/MiniSwiftTests/XCTestManifests.swift

+    // DO NOT MODIFY: This is autogenerated, use:
+    //   `swift test --generate-linuxmain`
+    // to regenerate.
+    static let __allTests__PromiseTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__PromiseTests' (identifier_name)

hound · 2019-09-30T14:36:27Z

Tests/MiniSwiftTests/XCTestManifests.swift

+    // DO NOT MODIFY: This is autogenerated, use:
+    //   `swift test --generate-linuxmain`
+    // to regenerate.
+    static let __allTests__DispatchQueueTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__DispatchQueueTests' (identifier_name)

hound · 2019-09-30T14:36:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

@@ -16,7 +16,16 @@ extension DictionaryExtensionsTests {
    // to regenerate.
    static let __allTests__DictionaryExtensionsTests = [
        ("test_get_or_put", test_get_or_put),
-        ("test_unrapping_subscript", test_unrapping_subscript)
+        ("test_unrapping_subscript", test_unrapping_subscript),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T14:36:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

@@ -6,7 +6,7 @@ extension ChainTests {
    //   `swift test --generate-linuxmain`
    // to regenerate.
    static let __allTests__ChainTests = [
-        ("test_forwarding_chain_forwards_action", test_forwarding_chain_forwards_action)
+        ("test_forwarding_chain_forwards_action", test_forwarding_chain_forwards_action),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-09-30T14:36:28Z

Tests/MiniSwiftTests/Utils/Foundation/DispatchQueueTests.swift

+@testable import MiniSwift
+
+final class DispatchQueueTests: XCTestCase {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-09-30T14:36:28Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+                .just(1)
+                .action(TestCompletableAction.self)
+                .toBlocking(timeout: 5.0).first() else { fatalError() }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:56Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    }
+
+    func test_completable_action_action() throws {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:57Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+                .contains(action: TestKeyedCompletableAction(promise: ["hello": .error(Error.dummy)]))
+        ).toEventually(beTrue())
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:57Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+            .error(Error.dummy)
+            .dispatch(action: TestKeyedCompletableAction.self, key: "hello", on: dispatcher)
+            .disposed(by: disposeBag)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:57Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    }
+
+    func test_keyed_completable_action_dispatch_error() {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:57Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+                .contains(action: TestKeyedCompletableAction(promise: ["hello": .value(1)]))
+        ).toEventually(beTrue())
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:58Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+            self.testMiddleware.actions(of: TestCompletableAction.self).count
+        ).toEventually(be(1))
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:59Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+            .just(1)
+            .dispatch(action: TestCompletableAction.self, on: dispatcher)
+            .disposed(by: disposeBag)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:59Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    }
+
+    func test_completable_action_dispatch() {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:59Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+        testMiddleware = TestMiddleware()
+        dispatcher.add(middleware: testMiddleware)
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:23:59Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+
+    override func setUp() {
+        super.setUp()
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:40Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    var dispatcher: Dispatcher!
+    var disposeBag: DisposeBag!
+    var testMiddleware: TestMiddleware!
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:40Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+        }
+
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:40Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+            guard let action = other as? TestEmptyAction else { return false }
+            return promise == action.promise
+        }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:40Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+        required init(promise: Promise<Void>) {
+            self.promise = promise
+        }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:41Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    class TestEmptyAction: EmptyAction {
+
+        let promise: Promise<Void>
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:42Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    class TestKeyedCompletableAction: KeyedCompletableAction {
+
+        typealias Payload = Int
+        typealias Key = String


Nesting Violation: Types should be nested at most 1 level deep (nesting)

hound · 2019-10-01T08:27:42Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+
+    class TestKeyedCompletableAction: KeyedCompletableAction {
+
+        typealias Payload = Int


Nesting Violation: Types should be nested at most 1 level deep (nesting)

hound · 2019-10-01T08:27:42Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    }
+
+    class TestKeyedCompletableAction: KeyedCompletableAction {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:42Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+            return counter == action.counter
+        }
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:27:42Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+        required init(promise: Promise<Payload?>) {
+            counter = promise
+        }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:07Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+        typealias Payload = Int
+
+        let counter: Promise<Payload?>
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:08Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    class TestCompletableAction: CompletableAction {
+
+        typealias Payload = Int
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:09Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+
+    class TestCompletableAction: CompletableAction {
+
+        typealias Payload = Int


Nesting Violation: Types should be nested at most 1 level deep (nesting)

hound · 2019-10-01T08:30:09Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+    fileprivate enum Error: Swift.Error { case dummy }
+
+    class TestCompletableAction: CompletableAction {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:09Z

Tests/MiniSwiftTests/RxTests/PrimitiveSequenceTypeTests.swift

+final class PrimitiveSequenceTypeTests: XCTestCase {
+
+    fileprivate enum Error: Swift.Error { case dummy }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:10Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+        XCTAssertTrue(state.counter.error == nil)
+        XCTAssertEqual(state.counter.value, 1)
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:10Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+            else {
+                fatalError()
+        }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:10Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+        store
+            .reducerGroup
+            .disposed(by: disposeBag)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:11Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+    func test_dispatch_action_from_store() throws {
+        let dispatcher = Dispatcher()
+        let store = Store<TestState, TestStoreController>(TestState(), dispatcher: dispatcher, storeController: TestStoreController(dispatcher: dispatcher))
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:11Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+
+    func test_dispatch_action_from_store() throws {
+        let dispatcher = Dispatcher()
+        let store = Store<TestState, TestStoreController>(TestState(), dispatcher: dispatcher, storeController: TestStoreController(dispatcher: dispatcher))


Line Length Violation: Line should be 120 characters or less: currently 156 characters (line_length)

hound · 2019-10-01T08:30:37Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+            .completed(20)
+        ])
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:38Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+        .disposed(by: disposeBag)
+
+        scheduler.start()
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:38Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+        .filterOne { $0 == 20 }
+        .subscribe(filterOneObserver)
+        .disposed(by: disposeBag)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:38Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+
+    func test_filter_one() {
+        let filterOneObserver = scheduler.createObserver(Int.self)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:38Z

Tests/MiniSwiftTests/RxTests/ObservableTypeTests.swift

+
+    var scheduler: TestScheduler!
+    var disposeBag: DisposeBag!
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:39Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertTrue(promise1 == promise2)
+
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:39Z

Tests/MiniSwiftTests/PromiseTests.swift

+        let promise2: Promise<Int> = .pending()
+
+        XCTAssertTrue(promise1 == promise2)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:40Z

Tests/MiniSwiftTests/PromiseTests.swift

+
+        let promise1: Promise<Int> = .pending()
+        let promise2: Promise<Int> = .pending()
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:40Z

Tests/MiniSwiftTests/PromiseTests.swift

+    }
+
+    func test_equality_pending() {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:40Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertFalse(promise1 == promise2)
+
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:59Z

Tests/MiniSwiftTests/PromiseTests.swift

+        let promise2: Promise<Int> = .value(2)
+
+        XCTAssertFalse(promise1 == promise2)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:59Z

Tests/MiniSwiftTests/PromiseTests.swift

+
+        let promise1: Promise<Int> = .value(1)
+        let promise2: Promise<Int> = .value(2)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:59Z

Tests/MiniSwiftTests/PromiseTests.swift

+    }
+
+    func test_equality_with_value() {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:59Z

Tests/MiniSwiftTests/PromiseTests.swift

+
+        XCTAssertFalse(promise.value! == 2)
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:30:59Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertFalse(promise.isPending)
+
+        promise.fulfill(2)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:31:01Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertFalse(promise.isPending)
+
+        if case .success? = promise.result {
+            XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

hound · 2019-10-01T08:31:01Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertFalse(promise.isFulfilled)
+        XCTAssertTrue(promise.isResolved)
+        XCTAssertFalse(promise.isPending)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:31:01Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertFalse(promise.isFulfilled)
+
+        promise.reject(Error.dummy)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:31:01Z

Tests/MiniSwiftTests/PromiseTests.swift

+        let promise: Promise<Int> = Promise<Int>()
+
+        XCTAssertFalse(promise.isFulfilled)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-01T08:31:02Z

Tests/MiniSwiftTests/PromiseTests.swift

+
+    func test_reject() {
+        let promise: Promise<Int> = Promise<Int>()
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T06:25:51Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

        -> Single<A> {
        return Single.create { single in
            let subscription = self.subscribe { event in
                switch event {
                case .completed:
-                    let action = A(task: Task.requestSuccess(expiration), payload: nil)
+                    let action = A.init(promise: .value(()))


Explicit Init Violation: Explicitly calling .init() should be avoided. (explicit_init)

hound · 2019-10-02T06:25:51Z

Sources/Mini/Utils/Foundation/Dictionary+Extensions.swift

+    public func resolve(with other: [Key: Value]) -> Self {
+        return self.merging(other, uniquingKeysWith: { _, new in new })
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:20Z

Sources/Mini/Promise.swift

+}
+
+extension Promise where T == Never {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:20Z

Sources/Mini/Promise.swift

+    var isPending: Bool {
+        return !isIdle && (result == nil && !isCompleted)
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:20Z

Sources/Mini/Promise.swift

+        box.fill(sealant)
+        properties = options
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:20Z

Sources/Mini/Box.swift

+    override func seal(_: T) {
+        // NO-OP
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:21Z

Sources/Mini/Box.swift

+    override func inspect() -> Sealant<T> {
+        return sealant
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:21Z

Sources/Mini/Box.swift

+final class PreSealedBox<T>: Box<T> {
+
+    private var sealant: Sealant<T> = .completed
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

hound · 2019-10-02T07:55:21Z

Sources/Mini/Box.swift

+}
+
+final class PreSealedBox<T>: Box<T> {
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

r-pedraza · 2019-10-04T10:39:35Z

Sources/Mini/Utils/OrderedSet.swift

@@ -159,7 +159,13 @@ public class OrderedSet<T: Comparable> {

    /// For each function
    public func forEach(_ body: (T) -> Swift.Void) {
-        return internalSet.forEach(body)


why do you use NSArray?

Only NSArray has the functionality to make a concurrent access to its items, speeding up the Action spreading.

hound · 2019-10-08T07:53:04Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

                // swiftlint:disable:next explicit_init
-                let action = A.init(task: .requestFailure(error))
+                let action = A(promise: .error(error))


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:04Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

            switch completable {
            case .completed:
                // swiftlint:disable:next explicit_init
-                let action = A.init(task: .requestSuccess(expiration))
+                let action = A(promise: .never())


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:04Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

+                        action = A(promise: .value(errorPayload))
+                    } else {
+                        // swiftlint:disable:next explicit_init
+                        action = A(promise: .error(error))


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:05Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

+                    var action: A
+                    if let errorPayload = errorPayload {
+                        // swiftlint:disable:next explicit_init
+                        action = A(promise: .value(errorPayload))


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:05Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

            let subscription = self.subscribe(
                onSuccess: { payload in
                    // swiftlint:disable:next explicit_init
-                    let action = A.init(task: .requestSuccess(expiration), payload: payload)
+                    let action = A(promise: .value(payload))


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:06Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

+                var action: A
+                if let errorPayload = errorPayload {
+                    // swiftlint:disable:next explicit_init
+                    action = A(promise: .value(errorPayload))


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:06Z

Sources/Mini/Utils/RxSwift/PrimitiveSequenceType+Extensions.swift

            onSuccess: { payload in
                // swiftlint:disable:next explicit_init
-                let action = A.init(task: .requestSuccess(expiration), payload: payload)
+                let action = A(promise: .value(payload))


Superfluous Disable Command Violation: SwiftLint rule 'explicit_init' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

hound · 2019-10-08T07:53:06Z

Package.swift

        .testTarget(
            name: "MiniSwiftTests",
-            dependencies: ["MiniSwift", "RxSwift"]),
+            dependencies: ["Mini", "TestMiddleware", "NIOConcurrencyHelpers", "RxSwift", "Nimble", "RxTest", "RxBlocking"]
+        ), // dev


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-10-08T07:53:06Z

Package.swift

+        .library(
+            name: "Mini/Test",
+            targets: ["Mini", "TestMiddleware"]
+        ),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

hound · 2019-10-08T07:53:07Z

Package.swift

@@ -8,28 +8,67 @@ let package = Package(
    platforms: [
        .iOS(.v11),
        .macOS(.v10_13),
-        .tvOS(.v11)
+        .tvOS(.v11),


Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

sebastianvarela

We need to talk about the integrations made in this PR because you have several changes in tools, scripts, dependencies and this changes should be discussed with the team.

hound · 2019-10-08T13:26:10Z

docs/Mini.swift

+extension PrimitiveSequenceType where Self: RxSwift.ObservableConvertibleType, Self.Trait == RxSwift.SingleTrait {
+    public func dispatch<A>(action: A.Type, on dispatcher: MiniSwift.Dispatcher, mode: MiniSwift.Dispatcher.DispatchMode.UI = .async, fillOnError errorPayload: A.Payload? = nil) -> RxSwift.Disposable where A: MiniSwift.CompletableAction, Self.Element == A.Payload
+
+    public func dispatch<A>(action: A.Type, key: A.Key, on dispatcher: MiniSwift.Dispatcher, mode: MiniSwift.Dispatcher.DispatchMode.UI = .async, fillOnError errorPayload: A.Payload? = nil) -> RxSwift.Disposable where A: MiniSwift.KeyedCompletableAction, Self.Element == A.Payload


Line Length Violation: Line should be 250 characters or less: currently 280 characters (line_length)

hound · 2019-10-08T13:26:10Z

docs/Mini.swift

+}
+
+extension PrimitiveSequenceType where Self: RxSwift.ObservableConvertibleType, Self.Trait == RxSwift.SingleTrait {
+    public func dispatch<A>(action: A.Type, on dispatcher: MiniSwift.Dispatcher, mode: MiniSwift.Dispatcher.DispatchMode.UI = .async, fillOnError errorPayload: A.Payload? = nil) -> RxSwift.Disposable where A: MiniSwift.CompletableAction, Self.Element == A.Payload


Line Length Violation: Line should be 250 characters or less: currently 263 characters (line_length)

hound · 2019-10-08T13:26:10Z

docs/Mini.swift

+extension ObservableType where Self.Element: MiniSwift.StoreType, Self.Element: RxSwift.ObservableType, Self.Element.Element == Self.Element.State {
+    public static func dispatch<A, Type, T>(using dispatcher: MiniSwift.Dispatcher, factory action: @autoclosure @escaping () -> A, taskMap: @escaping (Self.Element.State) -> T?, on store: Self.Element, lifetime: MiniSwift.Promises.Lifetime = .once) -> RxSwift.Observable<Self.Element.State> where A: MiniSwift.Action, T: MiniSwift.Promise<Type>
+
+    public static func dispatch<A, K, Type, T>(using dispatcher: MiniSwift.Dispatcher, factory action: @autoclosure @escaping () -> A, key: K, taskMap: @escaping (Self.Element.State) -> [K: T], on store: Self.Element, lifetime: MiniSwift.Promises.Lifetime = .once) -> RxSwift.Observable<Self.Element.State> where A: MiniSwift.Action, K: Hashable, T: MiniSwift.Promise<Type>


Line Length Violation: Line should be 250 characters or less: currently 373 characters (line_length)

hound · 2019-10-08T13:26:10Z

docs/Mini.swift

+}
+
+extension ObservableType where Self.Element: MiniSwift.StoreType, Self.Element: RxSwift.ObservableType, Self.Element.Element == Self.Element.State {
+    public static func dispatch<A, Type, T>(using dispatcher: MiniSwift.Dispatcher, factory action: @autoclosure @escaping () -> A, taskMap: @escaping (Self.Element.State) -> T?, on store: Self.Element, lifetime: MiniSwift.Promises.Lifetime = .once) -> RxSwift.Observable<Self.Element.State> where A: MiniSwift.Action, T: MiniSwift.Promise<Type>


Line Length Violation: Line should be 250 characters or less: currently 345 characters (line_length)

hound · 2019-10-08T13:26:10Z

docs/Mini.swift

+}
+
+extension DispatchQueue {
+    public static var isMain: Bool { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T13:26:11Z

docs/Mini.swift

+
+    public subscript(_: Key, orPut _: @autoclosure () -> Value) -> Value { get }
+
+    public subscript(_: Key) -> Value? { get }


Implicit Getter Violation: Computed read-only subscripts should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T13:26:11Z

docs/Mini.swift

+
+    public func get(withKey key: Key) -> Value?
+
+    public subscript(_: Key, orPut _: @autoclosure () -> Value) -> Value { get }


Implicit Getter Violation: Computed read-only subscripts should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T13:26:12Z

docs/Mini.swift

+}
+
+public final class RootChain: MiniSwift.Chain {
+    public var proceed: MiniSwift.Next { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T13:26:12Z

docs/Mini.swift

+    /**
+     - Returns: The error with which this promise was rejected or `nil` if this promise is pending or fulfilled.
+     */
+    public var error: Error? { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T13:26:12Z

docs/Mini.swift

+    /**
+     - Returns: The value with which this promise was fulfilled or `nil` if this promise is pending or rejected.
+     */
+    public var value: T? { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

- Fixed Cocoapods subspecs - Added different Mini targets for Testing and Logging.

Added more tests

…ripts

hound · 2019-10-08T14:04:00Z

docs/Mini.swift

+    /**
+     - Returns: `true` if the promise was rejected.
+     */
+    public var isRejected: Bool { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:01Z

docs/Mini.swift

+    /**
+     - Returns: `true` if the promise was fulfilled.
+     */
+    public var isFulfilled: Bool { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:01Z

docs/Mini.swift

+    /**
+     - Returns: `true` if the promise has resolved.
+     */
+    public var isResolved: Bool { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:01Z

docs/Mini.swift

+    /**
+     - Returns: `true` if the promise has not yet resolved.
+     */
+    public var isPending: Bool { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:01Z

docs/Mini.swift

+    /**
+     - Returns: `true` if the promise has not yet resolved nor pending.
+     */
+    public var isIdle: Bool { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:03Z

docs/Mini.swift

+    public init(initial: [T] = [])
+
+    /// Returns the number of elements in the OrderedSet.
+    public var count: Int { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:03Z

docs/Mini.swift

+public class LoggingService: MiniSwift.Service {
+    public var id: UUID
+
+    public var perform: MiniSwift.ServiceChain { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:04Z

docs/Mini.swift

+}
+
+public final class ForwardingChain: MiniSwift.Chain {
+    public var proceed: MiniSwift.Next { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:04Z

docs/Mini.swift

+        }
+    }
+
+    public var subscriptionCount: Int { get }


Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)

hound · 2019-10-08T14:04:04Z

docs/Mini.swift

+
+public final class Dispatcher {
+    public struct DispatchMode {
+        public enum UI {


Nesting Violation: Types should be nested at most 1 level deep (nesting)
Type Name Violation: Type name should be between 3 and 40 characters long: 'UI' (type_name)

hound · 2019-10-08T14:37:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        ]
+    }
+
+    public func __allTests() -> [XCTestCaseEntry] {


Identifier Name Violation: Function name should start with a lowercase character: '__allTests()' (identifier_name)

hound · 2019-10-08T14:37:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        // DO NOT MODIFY: This is autogenerated, use:
+        //   `swift test --generate-linuxmain`
+        // to regenerate.
+        static let __allTests__ReducerTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__ReducerTests' (identifier_name)

hound · 2019-10-08T14:37:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        // DO NOT MODIFY: This is autogenerated, use:
+        //   `swift test --generate-linuxmain`
+        // to regenerate.
+        static let __allTests__PromiseTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__PromiseTests' (identifier_name)

hound · 2019-10-08T14:37:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        // DO NOT MODIFY: This is autogenerated, use:
+        //   `swift test --generate-linuxmain`
+        // to regenerate.
+        static let __allTests__PrimitiveSequenceTypeTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__PrimitiveSequenceTypeTests' (identifier_name)

hound · 2019-10-08T14:37:28Z

Tests/MiniSwiftTests/XCTestManifests.swift

+        // DO NOT MODIFY: This is autogenerated, use:
+        //   `swift test --generate-linuxmain`
+        // to regenerate.
+        static let __allTests__ObservableTypeTests = [


Identifier Name Violation: Variable name should only contain alphanumeric characters: '__allTests__ObservableTypeTests' (identifier_name)

hound · 2019-10-08T14:37:30Z

Tests/MiniSwiftTests/ReducerTests.swift

+        store
+            .map { $0.counter.value }
+            .filter { $0 != nil }
+            .subscribe(onNext: { _counter in


Identifier Name Violation: Variable name should only contain alphanumeric characters: '_counter' (identifier_name)

hound · 2019-10-08T14:37:30Z

Tests/MiniSwiftTests/ReducerTests.swift

+        store
+            .map { $0.counter.value }
+            .filter { $0 != nil }
+            .subscribe(onNext: { _counter in


Identifier Name Violation: Variable name should only contain alphanumeric characters: '_counter' (identifier_name)

hound · 2019-10-08T14:37:30Z

Tests/MiniSwiftTests/ReducerTests.swift

+        store
+            .map { $0.counter.value }
+            .filter { $0 != nil }
+            .subscribe(onNext: { _counter in


Identifier Name Violation: Variable name should only contain alphanumeric characters: '_counter' (identifier_name)

hound · 2019-10-08T14:37:30Z

Tests/MiniSwiftTests/ReducerTests.swift

+        store
+            .map { $0.counter.value }
+            .filter { $0 != nil }
+            .subscribe(onNext: { _counter in


Identifier Name Violation: Variable name should only contain alphanumeric characters: '_counter' (identifier_name)

hound · 2019-10-08T14:37:31Z

Tests/MiniSwiftTests/PromiseTests.swift

+        XCTAssertFalse(promise.isPending)
+
+        if case .failure? = promise.result {
+            XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

minuscorp added the enhancement New feature or request label Sep 17, 2019

minuscorp self-assigned this Sep 17, 2019

hound bot reviewed Sep 23, 2019

View reviewed changes

hound bot reviewed Sep 27, 2019

View reviewed changes

hound bot reviewed Sep 30, 2019

View reviewed changes

minuscorp marked this pull request as ready for review September 30, 2019 14:30

minuscorp requested review from EdiLT, r-pedraza and sebastianvarela as code owners September 30, 2019 14:30

minuscorp changed the title ~~Draft proposal: Deprecate Task, use a Promise-based approach~~ Deprecate Task, use a Promise-based approach. v2.0.0 proposal Sep 30, 2019

hound bot reviewed Sep 30, 2019

View reviewed changes

hound bot reviewed Oct 1, 2019

View reviewed changes

hound bot reviewed Oct 2, 2019

View reviewed changes

EdiLT approved these changes Oct 4, 2019

View reviewed changes

r-pedraza reviewed Oct 4, 2019

View reviewed changes

hound bot reviewed Oct 8, 2019

View reviewed changes

sebastianvarela requested changes Oct 8, 2019

View reviewed changes

hound bot reviewed Oct 8, 2019

View reviewed changes

sebastianvarela approved these changes Oct 8, 2019

View reviewed changes

minuscorp added 3 commits October 8, 2019 16:02

Draft proposal: Deprecate Task, use a Promise-based approach

8b650b4

Added support for fulfill and reject

f93b0c0

swiftlint

a761440

minuscorp and others added 23 commits October 8, 2019 16:02

Don't clear derivedData, clean flag is already set up

796c09a

swiftlint

0ccec53

testing platform improvements

84e4659

Added automation and prepare for future release

c122108

Added git hooks

6678b8a

Added git hooks

6f1f5a7

Remove deprecated lane

fcdc10f

Switch back to xcodebuild

802938c

Fix xcodebuild execution path

88f4abe

Remove .swift-version file

f104e79

Fix hound warnings

0088d94

Remap project directories.

885fc58

- Fixed Cocoapods subspecs - Added different Mini targets for Testing and Logging.

Fix swiftlint directories

27282b9

Fix Hound comments

8fffbb1

Commentary review

d37308f

Added Promise<Never> capabilities

9613489

Added more tests

Added Equatable for Promise<Never>

296c5d0

Fix build

8cfc4f0

swiftlint

64d1afa

Update git scripts

8648f20

Hound comments

1c62977

Add Action and ActionReducer docs

4d580c7

Refactor: Move documentation to docs/ folder and remove deprecated sc…

b11dc8b

…ripts

sebastianvarela force-pushed the experimental-promises branch from 194e6e1 to b11dc8b Compare October 8, 2019 14:03

hound bot reviewed Oct 8, 2019

View reviewed changes

Changes before merge

46b8481

hound bot reviewed Oct 8, 2019

View reviewed changes

sebastianvarela merged commit 46b8481 into master Oct 8, 2019

github-pages bot deployed to github-pages October 8, 2019 15:48 View deployment

github-pages bot deployed to github-pages October 8, 2019 15:50 View deployment


		interface = JSON.parse(response)

		# Write just the interface all to a file, in theory we can make a HTML version of this in the future


		public subscript(_: Key, orPut _: @autoclosure () -> Value) -> Value { get }

		public subscript(_: Key) -> Value? { get }


		public func get(withKey key: Key) -> Value?

		public subscript(_: Key, orPut _: @autoclosure () -> Value) -> Value { get }

		@testable import MiniSwift

		final class DispatchQueueTests: XCTestCase {

		class TestEmptyAction: EmptyAction {

		let promise: Promise<Void>


		class TestKeyedCompletableAction: KeyedCompletableAction {

		typealias Payload = Int

		class TestCompletableAction: CompletableAction {

		typealias Payload = Int

		fileprivate enum Error: Swift.Error { case dummy }

		class TestCompletableAction: CompletableAction {

		final class PrimitiveSequenceTypeTests: XCTestCase {

		fileprivate enum Error: Swift.Error { case dummy }


		func test_filter_one() {
		let filterOneObserver = scheduler.createObserver(Int.self)

		let promise2: Promise<Int> = .pending()

		XCTAssertTrue(promise1 == promise2)


		let promise1: Promise<Int> = .pending()
		let promise2: Promise<Int> = .pending()

		let promise2: Promise<Int> = .value(2)

		XCTAssertFalse(promise1 == promise2)


		let promise1: Promise<Int> = .value(1)
		let promise2: Promise<Int> = .value(2)

		XCTAssertFalse(promise.isFulfilled)

		promise.reject(Error.dummy)

		let promise: Promise<Int> = Promise<Int>()

		XCTAssertFalse(promise.isFulfilled)


		func test_reject() {
		let promise: Promise<Int> = Promise<Int>()

		final class PreSealedBox<T>: Box<T> {

		private var sealant: Sealant<T> = .completed

Deprecate Task, use a Promise-based approach. v2.0.0 proposal #15

Deprecate Task, use a Promise-based approach. v2.0.0 proposal #15

Conversation

minuscorp commented Sep 17, 2019

sebastianvarela commented Sep 17, 2019 • edited

SwiftLint found issues

Warnings

Errors

codecov bot commented Sep 17, 2019 • edited

Codecov Report

hound bot Sep 23, 2019

Choose a reason for hiding this comment

hound bot Sep 27, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Sep 30, 2019

Choose a reason for hiding this comment

hound bot Oct 1, 2019

Choose a reason for hiding this comment

hound bot Oct 1, 2019

Choose a reason for hiding this comment

hound bot Oct 1, 2019

Choose a reason for hiding this comment

sebastianvarela commented Sep 17, 2019 •

edited

codecov bot commented Sep 17, 2019 •

edited