Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative One-Sided P-Values #29

Open
1 task done
RahulDaswani opened this issue Apr 22, 2019 · 1 comment
Open
1 task done

Negative One-Sided P-Values #29

RahulDaswani opened this issue Apr 22, 2019 · 1 comment
Labels
Need More Info Needs more information such as specific steps for reproducing a bug

Comments

@RahulDaswani
Copy link

Preliminaries

Before submitting an issue, please check (with x in brackets) that you:

  • Are using the newest release (see here for latest release version number).
  • [x ] Have checked that the examples in the help work.
  • [x ] Have read the help (HTML version).
  • [ x] Have checked that there is not already an existing issue for what you are reporting.
  • [ x] Have check running synth directly for one of the treated units works.

Hello,

Firstly, I just wanted to say a huge thanks for this tool. I am a final-year undergraduate Economics student and this has really helped with my dissertation.

I was looking to conduct one-sided p-values for a negative effect (in my case, all 'effects' in the post-intervention period are negative). However, when I enter the pvals1s code in the appropriate manner, as instructed by the help book, the outputted p-values are the same as if I would have excluded it. Ideally, I would like to use the tool to plot the one-sided p-values as in the same manner the 'pvals_graphs' command works.

As a note:

-I am using a Mac
-My Stata version is 15.1
-My synth_runner package is fully updated.

Thanks a lot! I hope you will be able to come back to me soon as my deadline is in 2 days!

Best,

Rahul

@bquistorff
Copy link
Owner

When you add the pvals1s option then a new return value of e(pvals_1s) should be included. Are you seeing that?

@bquistorff bquistorff added the Need More Info Needs more information such as specific steps for reproducing a bug label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need More Info Needs more information such as specific steps for reproducing a bug
Projects
None yet
Development

No branches or pull requests

2 participants