Rendering update #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JeanCGedeon <JeanCGedeon@users.noreply.github.com> Co-authored-by: Tyler <br.ndt.tyler@gmail.com> Co-authored-by: camziny <camziny@users.noreply.github.com>
fix front-end post request for reviews (added userId in state) merge attractionReviewsRouter merge from 4232cef Co-authored-by: Tyler <br.ndt.tyler@gmail.com> Co-authored-by: camziny <camziny@users.noreply.github.com>
nwalberts
requested changes
May 6, 2022
| } catch (error) { | ||
| return res.status(500).json({ errors: error }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
user id should come from your passport session, via req.user, not from the frontend.
There was a problem hiding this comment.
there is also no ValidationError handling here. You are handling for these types of errors on the frontend, but in this implementation those errors would never be used
nwalberts
reviewed
May 9, 2022
add locationAttractionsRouter remove placeholders from forms incorporate user session data add authenticated routes for forms add Location dropdown to NewAttractionForm Co-authored-by: JeanCGedeon <JeanCGedeon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fetch request on the front-end
add userId into state on the front-end
edit the top bar
add attractionReviewsRouter(also update userId in the post request)