Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases should be signed. #31

Open
aaroncrespo opened this issue Apr 13, 2017 · 8 comments
Open

Releases should be signed. #31

aaroncrespo opened this issue Apr 13, 2017 · 8 comments

Comments

@aaroncrespo
Copy link

Downloaded the release but discovered that it isn't signed.

@keith
Copy link
Member

keith commented Apr 13, 2017

I may or may not end up signing these. I currently don't have a developer account and it feels a little silly to sign up for one just for this. We'll see. Thanks for filing this though!

@aaroncrespo
Copy link
Author

Yeah I get that.

This app asks for pretty sensitive information from a user and there is no guarantee whats on the release page is what is represented in code. If they aren't signed maybe think about not offering binary releases and require builds from source.

@keith
Copy link
Member

keith commented Apr 13, 2017

Well even if I developer signed the build you couldn't be sure that I built it from the commits on master. You may know that it's built by me, but you'd be in the same place 😄 . And since it wouldn't be going through the MAS there realistically wouldn't really be an accountability for it either.

@keith
Copy link
Member

keith commented Apr 13, 2017

FWIW I would obviously sign this if I had an account. I do see the value in it if not for anything but the friction that macOS has for running unsigned apps.

@aaroncrespo
Copy link
Author

Yup, but say something nefarious happened Apple could revoke the cert which would prevent installs/execution on Macs running Gatekeeper.

@Reflejo
Copy link

Reflejo commented Apr 13, 2017

Additionally someone with control to your github account can't compile a trustfully binary and distribute it on your name.

Having said that, I agree that it doesn't make sense for now to have a dev account for it and anyone can clone the repo and compile it.

@ZevEisenberg
Copy link
Contributor

An annoying side effect is having to deal with the keychain stuff whenever you download a new build. If the build is signed, it can access the keychain across builds, as far as I understand it.

Maybe it would be worth trying to get a company to sponsor a developer account for this project? $100/year is pretty low, and they'd presumably get a sponsorship plug on the readme.

@funkenstrahlen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants