Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't this be +, not -? #28

Closed
mathvav opened this issue May 28, 2015 · 1 comment
Closed

Shouldn't this be +, not -? #28

mathvav opened this issue May 28, 2015 · 1 comment

Comments

@mathvav
Copy link

mathvav commented May 28, 2015

Here, there is this line of code:

double output = kp * error + ITerm- kd * dInput;

Shouldn't it be this?:

double output = kp * error + ITerm + kd * dInput;
//                                 ^ (switched from -)

Am I reading this wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants