[CLOSED] Extension manager now scrolls to top when search filters are added/removed

[core-ai-bot]

Issue by nhickok
Monday Sep 14, 2015 at 03:46 GMT
Originally opened as adobe/brackets#11700

---

In reference to bug #10611:

I took into account the feedback on the previous attempt to fix this bug (#11178) and implemented the suggested changes (i.e. added $(".modal-body", $dlg).scrollTop(0); below both calls to view.filter(...)). All unit tests pass and the feature works as intended when search filters are added/removed.

---

nhickok included the following code: https://github.com/adobe/brackets/pull/11700/commits

[core-ai-bot]

Comment by ingorichter
Monday Sep 14, 2015 at 06:10 GMT

---

@stowball do you have a minute to verify that this fixes the issue for you?

[core-ai-bot]

Comment by ficristo
Monday Sep 14, 2015 at 06:26 GMT

---

This seems a duplicate of #11378

[core-ai-bot]

Comment by nhickok
Monday Sep 14, 2015 at 06:29 GMT

---

You're right, they are both the same. I must not have noticed it. I'll close this pull request.

[core-ai-bot]

Comment by stowball
Monday Sep 14, 2015 at 06:30 GMT

---

Yep, this works as expected. I wonder whether we should now be caching $(".modal-body", $dlg) in to its own variable since its called 5 times?

[core-ai-bot]

Comment by ingorichter
Monday Sep 14, 2015 at 16:00 GMT

---

Yes, assign to it's own variable is a good idea.

[core-ai-bot]

Comment by mansimarkaur
Tuesday Sep 27, 2016 at 12:47 GMT

---

Does $(".modal-body", $dlg) still need to be assigned to it's own variable?

[core-ai-bot]

Comment by ficristo
Tuesday Sep 27, 2016 at 18:56 GMT

---

Yes, do you want to take a look?
It seems to me that@darkcoderrises will not fix it in his PR at #11378, so go ahead if you want.

[core-ai-bot]

Comment by mansimarkaur
Tuesday Sep 27, 2016 at 19:04 GMT

---

@stowball I think $(".modal-body", $dlg) is being used thrice only in ExtensionManagerDialog.js and not 5 times anywhere. Please correct me if I'm wrong.