Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Add new pref: lineWiseCopyCut #10137

Open
core-ai-bot opened this issue Aug 30, 2021 · 9 comments
Open

[CLOSED] Add new pref: lineWiseCopyCut #10137

core-ai-bot opened this issue Aug 30, 2021 · 9 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Tuesday Sep 15, 2015 at 12:52 GMT
Originally opened as adobe/brackets#11706


For #9311. Adds a new pref lineWiseCopyCut (still enabled by default) to suppress copy/cut from copying/cutting a whole line when there's no selection.

See also http://codemirror.net/doc/manual.html#option_lineWiseCopyCut.


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/11706/commits

@core-ai-bot
Copy link
Member Author

Comment by le717
Wednesday Sep 16, 2015 at 17:23 GMT


I don't think this is quite the issue reported. The problem was not whole-line cut/copy as a feature, but that it copy/pastes a totally blank line when used on a blank line. The desired fix was for it to not activate at all on blank lines. The issue, as I already detailed, is the "\n" CodeMirror always adds to the end of the copied line. With those removed (more like added only under proper circumstances), using whole-line cut/copy on a blank line works as desired (and also as I said, remedies a number described in #9130).

EDIT: I could be reading this all wrong and this PR does exactly what needs to be done instead of completely disabling the feature (as I initially thought). Apologies if that is the case. :\

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Wednesday Sep 16, 2015 at 18:09 GMT


This actually is what you think it is.
The pref, when disabled, disables the whole copy-line-where-cursor-is-on feature.

Even though this may not be the exact solution to the referenced issue, I guess it is a step in the right direction either way.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Saturday Jan 30, 2016 at 10:36 GMT


This options seems useful to me. I like this.
/cc@swmitra@nethip

@core-ai-bot
Copy link
Member Author

Comment by Denisov21
Wednesday May 04, 2016 at 17:23 GMT


Good idea for me!

@core-ai-bot
Copy link
Member Author

Comment by M4TH76
Sunday Jun 12, 2016 at 16:52 GMT


That would really help me, I often accidentally blind type Ctrl-C instead of Ctrl-V

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Wednesday Jul 20, 2016 at 18:22 GMT


LGTM, but the description is not correct: is not only about empty lines.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Saturday Jul 23, 2016 at 20:30 GMT


Argh, now it's back to almost exactly the wording the CM manual uses.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Sunday Jul 24, 2016 at 07:12 GMT


Thank you, LGTM.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Jul 24, 2016 at 08:05 GMT


Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant