Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Can't toggle comments in SQL documents #10734

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

[CLOSED] Can't toggle comments in SQL documents #10734

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by edelsonc
Thursday Jul 07, 2016 at 02:43 GMT
Originally opened as adobe/brackets#12577


Hello

Comment toggling doesn't work on OS X in .sql scripts.

I'm using Brackets Release 1.7.

Thanks

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Wednesday Jul 13, 2016 at 10:17 GMT


Seems a general problem: tryed with sql, cc, and js snippet of code.

/*
 *  Comment adjacent to the gutter cannot be folded.
 */
 /*
 *  Comment with one space between the gutter can be folded.
 */

/cc@thehogfather

@core-ai-bot
Copy link
Member Author

Comment by thehogfather
Friday Jul 22, 2016 at 09:34 GMT


@edelsonc @ficristo This is a bug from the version of CodeMirror included in Brackets. The issue will disappear once brackets upgrades code mirror whenever that is.

As a workaround, the comments are foldable if there is a space before the first /*.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Friday Jul 22, 2016 at 09:48 GMT


@thehogfather good to know!

Another thing is that would be nice to be able to collapse comments that span on multiple lines (and use line comments).

-- A comment
-- that span
-- on multiple lines

Maybe too hard / peformance sensitive but still...

@edelsonc I'm sorry to have hijacket your issue...

@core-ai-bot
Copy link
Member Author

Comment by thehogfather
Friday Jul 22, 2016 at 11:40 GMT


@ficristo would require writing a range finder for single line comments that span multiple consecutive lines - so not too hard.

Might be worth creating a separate issue so we can discuss the implications of such a use case. The actual range finder should be relatively easy to write.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Wednesday Aug 10, 2016 at 12:22 GMT


We update CodeMirror and@thehogfather fixed a problem with CodeFolding, both of which should be available on 1.8.
Closing since it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant