[CLOSED] Fixes translation error in Simplified Chinese

[core-ai-bot]

Issue by mjaseem
Sunday Jun 18, 2017 at 13:22 GMT
Originally opened as adobe/brackets#13463

---

Fixes adobe/brackets/issues/13416

---

mjaseem included the following code: https://github.com/adobe/brackets/pull/13463/commits

[core-ai-bot]

Comment by mjaseem
Sunday Jun 18, 2017 at 13:46 GMT

---

Didn't expect build to fail for a change in translation. Why does it happen?
This is my first PR to any project, btw.

[core-ai-bot]

Comment by ficristo
Sunday Jun 18, 2017 at 16:18 GMT

---

If you click on the red x it redirects you to the continuos integration site we are using with the result of your PR. There are more info there.
In your case it first failed because of the api rate limit of GitHub (I think Brackets is using a free GitHub account which has a low rate limit), and now because of the CLA.

mjaseem has NOT submitted the contributor license agreement. See http://dev.brackets.io/brackets-contributor-license-agreement.html.

Also do you know someone who could review this ?

[core-ai-bot]

Comment by mjaseem
Monday Jun 19, 2017 at 10:16 GMT

---

I assume the reviewer needs to be someone who's part of the project and understand Chinese. I don't know anyone like that.

I have now signed the CLA with my new username.

[core-ai-bot]

Comment by ficristo
Monday Jun 19, 2017 at 19:14 GMT

---

You just need someone who knows Chinese.
Then someone of the Brackets team can merge.

[core-ai-bot]

Comment by mjaseem
Tuesday Jun 20, 2017 at 13:41 GMT

---

@jiajun0308 @xiaoyu2016 Could you review this?

[core-ai-bot]

Comment by ficristo
Tuesday Jun 20, 2017 at 17:53 GMT

---

Also@FallingHeart, could you review this ?

[core-ai-bot]

Comment by FallingHeart
Wednesday Jun 21, 2017 at 00:56 GMT

---

of course@ficristo
the translation error has been fixed
but what am i supposed to do
or just say yes here

[core-ai-bot]

Comment by ficristo
Wednesday Jun 21, 2017 at 17:41 GMT

---

Saying the translation is correct is enough.
For a more involved translation you could go to the "Files changed" tab and start a review / add comments.

@mjaseem@FallingHeart thank you!