Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Update _shouldShowInTree to only hide specified hidden files. #1150

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by TuckerWhitehouse
Wednesday Jun 27, 2012 at 00:22 GMT
Originally opened as adobe/brackets#1165


Solution for #1133


TuckerWhitehouse included the following code: https://github.com/adobe/brackets/pull/1165/commits

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Jun 27, 2012 at 22:12 GMT


Assigned to me. Reviewing.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Jun 27, 2012 at 22:53 GMT


Review done.@TuckerWhitehouse be sure to sign the CLA before I merge this pull request http://dev.brackets.io/brackets-contributor-license-agreement.html. Also, if you haven't already, run the unit tests on this branch. In Brackets, Debug > Run Tests.

@core-ai-bot
Copy link
Member Author

Comment by TuckerWhitehouse
Wednesday Jun 27, 2012 at 23:11 GMT


Already signed the CLA and ran the unit tests, passed 100%. I know it's just a temporary solution, but it at least is a little more extensible than the current implementation.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Jun 27, 2012 at 23:38 GMT


Can you try filling it out again?@adrocknaphobia is out at Google I/O, he'd normally handle CLA questions. I suspect the Github username field is case sensitive.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Jun 27, 2012 at 23:39 GMT


Nevermind. It is case sensitive. I'll have@adrocknaphobia fix it. Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant