-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Adding 64 bit binaries for CodeHelper.exe #12032
Comments
My changes are in forked repo |
Should the forked repo be brought under or adobe org ? It will be difficult to track the source of this change. Even the readme or wiki needs to be updated to identify the source of the 64bit binary. |
VSCode 64bit binary is still using the 32bit filewatcher, and since you haven't changed anything specific in the source, rather just the build platform, I'm not sure about this. A better approach would be to raise these forked changes as a PR against upstream, and see the response there. |
Yes "Any CPU" is good enough. So, don't need 64 bit build, |
Tuesday May 07, 2019 at 16:37 GMT
Originally opened as adobe/brackets#14784
have changed the icon for this binary to be same as brackets, corresponding to brackets-shell/Windows-x64 branch PR
jha-g included the following code: https://github.com/adobe/brackets/pull/14784/commits
The text was updated successfully, but these errors were encountered: