Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Refactor global brackets ready and htmlContentLoadComplete events to a new Global module #1401

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by jasonsanjose
Thursday Aug 23, 2012 at 16:27 GMT
Originally opened as adobe/brackets#1425



jasonsanjose included the following code: https://github.com/adobe/brackets/pull/1425/commits

@core-ai-bot
Copy link
Member Author

Comment by joelrbrandt
Friday Aug 24, 2012 at 17:51 GMT


@jason-sanjose are commits a031653 and 418a989 supposed to be part of this pull?

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Aug 24, 2012 at 17:53 GMT


Yes. Those unit tests broke after the refactoring.

@core-ai-bot
Copy link
Member Author

Comment by joelrbrandt
Friday Aug 24, 2012 at 18:37 GMT


@jason-sanjose initial review done -- lookin' good. Back at ya! Happy to chat over IRC if that's easier.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Aug 24, 2012 at 21:41 GMT


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant