[CLOSED] Menu name inconsistency: Lines vs. Line(s)

[core-ai-bot]

Issue by peterflynn
Monday Oct 22, 2012 at 22:59 GMT
Originally opened as adobe/brackets#1916

---

We have several menu items with inconsistent names:
Delete Line(s)
Move Line(s) Up
Move Line(s) Down
Comment/Uncomment Lines

I propose renaming as following:
Delete Line
Move Line Up
Move Line Down
Line Comment/Uncomment (or: Toggle Line Comment?)
(future: Block Comment/Uncomment) (or: Toggle Block Comment?)

Other editors use the singular form for "Line" in these commands even though they all also support multiple lines. The behavior is a common enough convention that I don't think users will be thrown by the labels not explicitly mentioning multiple lines.

[core-ai-bot]

Comment by peterflynn
Monday Oct 22, 2012 at 22:59 GMT

---

@njx, any thoughts?

[core-ai-bot]

Comment by jeffslofish
Tuesday Oct 23, 2012 at 01:30 GMT

---

Maybe it should say:

Move Line Up

when there is one line selected, and:

Move Lines Up

when multiple lines are selected, for this and all the line commands.

[core-ai-bot]

Comment by KraigWalker
Wednesday Oct 24, 2012 at 08:42 GMT

---

It should probably be changed to "Move Line Up"

However this would be because, like in other editors, the item describes the unit of distance that your moving the selection up by (a line)

I wouldn't recommend changing the description based on the user's selection however, as this could lead to user confusion (even if it's a very subtle variation)

Changing the title based on what the user has selected could also wreck search-based help in the future (click Help in Mac and you'll see a nifty little search bar - I use it all the time in Photoshop 🐼 )

I guess I'll fork the latest build and see about fitting it in?

[core-ai-bot]

Comment by KraigWalker
Wednesday Oct 24, 2012 at 09:05 GMT

---

Actually... Looking at it more closely (in the root strings file) and then comparing it with other stuff. It Should just be "Lines"

Much more sure, solid language, and implies that it's the 'lines' you have selected. Where actually having singular could also create confusion. So normal plural is best.

[core-ai-bot]

Comment by KraigWalker
Wednesday Oct 24, 2012 at 09:21 GMT

---

Sorted. See issue #1928

[core-ai-bot]

Comment by njx
Wednesday Oct 24, 2012 at 16:13 GMT

---

Hi there--thanks for putting some thought (and a pull request) into this. Looking at a few other editors, though, it seems like it's standard to just use the singular here, and I don't think people will be too confused by it. I agree with you that we shouldn't change it based on the selection.

Would you be willing to modify your pull request to make these singular? Thanks!

[core-ai-bot]

Comment by KraigWalker
Wednesday Oct 24, 2012 at 22:07 GMT

---

Modification has now been made on issue #1928

[core-ai-bot]

Comment by pthiess
Monday Oct 29, 2012 at 18:12 GMT

---

Reviewed.

[core-ai-bot]

Comment by njx
Monday Nov 19, 2012 at 23:56 GMT

---

FBNC to@peterflynn (forgot to do this when I merged it a long time ago)

[core-ai-bot]

Comment by peterflynn
Tuesday Dec 11, 2012 at 22:13 GMT

---

Oops, fell through the cracks a second time. Definitely fixed though, so closing.

[core-ai-bot]

Comment by peterflynn
Tuesday Dec 11, 2012 at 22:15 GMT

---

Btw,@KraigWalker: you mentioned way earlier in this thread that you like the feature other apps have where you can search all menu comments. Fyi, there's a actually a Brackets extension for that exact functionality: https://github.com/peterflynn/brackets-commands-guide