Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fix issue #1916 - Menu Name Inconsistency #1877

Open
core-ai-bot opened this issue Aug 29, 2021 · 8 comments
Open

[CLOSED] Fix issue #1916 - Menu Name Inconsistency #1877

core-ai-bot opened this issue Aug 29, 2021 · 8 comments

Comments

@core-ai-bot
Copy link
Member

Issue by KraigWalker
Wednesday Oct 24, 2012 at 09:14 GMT
Originally opened as adobe/brackets#1928


issue #1916

Minor Fix - Modified text for ''Delete/Move Lines" to use standard English
pluralization as opposed to "(s)"


KraigWalker included the following code: https://github.com/adobe/brackets/pull/1928/commits

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Oct 25, 2012 at 17:54 GMT


@KraigWalker: could you also update the "CMD_COMMENT" string, per the bug? I like the second form: "Toggle Line Comment."

@core-ai-bot
Copy link
Member Author

Comment by KraigWalker
Thursday Oct 25, 2012 at 21:41 GMT


is there an issue relating to that? I can check that out in the root strings anyway though.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Oct 25, 2012 at 22:32 GMT


Looks like it was mentioned in the original bug description for #1916.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Oct 29, 2012 at 18:12 GMT


Thanks for the update--will review today.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Oct 29, 2012 at 18:29 GMT


@KraigWalker: I think we'd actually prefer to name it "Toggle Line Comment" as mentioned in the bug (#1916).

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Oct 30, 2012 at 02:53 GMT


Looks good--thanks for deal with all our nitpicking :) Merging.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Oct 30, 2012 at 02:54 GMT


@KraigWalker -- oops, I forgot to ask if you signed our CLA. Could you go ahead and do that? (You only need to do it this one time--it's good for all future submissions.) http://dev.brackets.io/brackets-contributor-license-agreement.html

@core-ai-bot
Copy link
Member Author

Comment by KraigWalker
Tuesday Oct 30, 2012 at 10:41 GMT


Signed, sealed delivered!

On 30 Oct 2012, at 02:54, Narciso Jaramillo notifications@github.com wrote:

@KraigWalker -- oops, I forgot to ask if you signed our CLA. Could you go ahead and do that? (You only need to do it this one time--it's good for all future submissions.) http://dev.brackets.io/brackets-contributor-license-agreement.html


Reply to this email directly or view it on GitHub.

http://www.kraigwalker.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant