Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fix #2641: Input field change to blank after double click F2 to rename the file - few user will encounter #3102

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by TomMalbran
Saturday Mar 30, 2013 at 21:42 GMT
Originally opened as adobe/brackets#3299


This adds a renaming flag, so that when F2 is pressed for the second time, the code does nothing, leaving the renaming as it was, which fixes issue #2641.


TomMalbran included the following code: https://github.com/adobe/brackets/pull/3299/commits

@core-ai-bot
Copy link
Member Author

Comment by julianasuh
Monday Apr 01, 2013 at 17:23 GMT


Assigned@gruehle

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 01, 2013 at 17:49 GMT


Would it be better to just check ProjectManager._isInRename()?

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Apr 01, 2013 at 20:28 GMT


I didn't saw that function before. It should work to fix this too.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Tuesday Apr 23, 2013 at 20:08 GMT


Initial review complete. It works as advertised, but the _isInRename() check could be done earlier.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Wednesday Apr 24, 2013 at 16:17 GMT


Thanks! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant