You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comment by peterflynn Friday Apr 19, 2013 at 18:45 GMT
Even though this guards us against it, we should probably file a bug on CodeMirror too just to be a good citizen -- probably no client of CM would be happy with it going into an infinite loop when given a malformed tabs/spaces setting.
Comment by TomMalbran Saturday Apr 20, 2013 at 07:56 GMT
Right, but the manual specifies that the indentUnit and the tabSize should be integers, so it seems more of our fault for providing a float to the option. I checked the CodeMirror code an neither of the options have a guard against bad values supplied to them. But if this seems that should be fixed in CodeMirror too, then we should add a bug there too.
Comment by RaymondLim Wednesday Apr 24, 2013 at 06:15 GMT
I can't reproduce the infinite loop with a CodeMirror demo page. The only thing I can reproduce is the word "undefined" gets inserted at the beginning of the new line as indentation. Anyway, I will try to log one for this later.
Friday Apr 19, 2013 at 05:30 GMT
Originally opened as adobe/brackets#3487
Fix for issue #3466 by not letting the unit be a float value, by making it an integer before saving it.
TomMalbran included the following code: https://github.com/adobe/brackets/pull/3487/commits
The text was updated successfully, but these errors were encountered: