-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] move inline js into external files #4052
Comments
I personally prefer to have fewer files; would reduce program boot time & HD space. |
|
I've also made some fixes that should fix the CI build failures due to JSLint errors as well as adding the std adobe license header (as copied from brackets.js). |
Ah, I see ty.
|
|
Here's a good jsHint discussion on Automatic Semicolon Insertion (ASI): http://stackoverflow.com/questions/2846283/what-are-the-rules-for-javascripts-automatic-semicolon-insertion-asi |
The second file |
Good Catch |
|
|
|
in xorigin.js:
In dependencies.js
|
Changes look good!
|
Merged |
Sunday Jun 30, 2013 at 10:59 GMT
Originally opened as adobe/brackets#4374
chrome packaged apps are not allowed to use inline script elements and functionally there doesn't seem to be any reason to keep these as inline in index.html
maks included the following code: https://github.com/adobe/brackets/pull/4374/commits
The text was updated successfully, but these errors were encountered: