Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Cursor shows up on next line after collapsing Quick Doc (with word wrap enabled) #4224

Open
core-ai-bot opened this issue Aug 29, 2021 · 30 comments
Open

[CLOSED] Cursor shows up on next line after collapsing Quick Doc (with word wrap enabled) #4224

core-ai-bot opened this issue Aug 29, 2021 · 30 comments

Comments

@core-ai-bot
Copy link
Member

Issue by RaymondLim
Wednesday Jul 24, 2013 at 23:13 GMT
Originally opened as adobe/brackets#4564

  1. Delete \Users[username]\AppData\Roaming\Brackets\cef_data folder so that Brackets is open in the default window size with Word Wrap on by default.
  2. Launch Brackets and open main.css from the default "Getting Started" project.
  3. Set cursor on a CSS property (eg. margin) and hit Ctrl+K.
  4. After Quick Doc opens, hit Ctrl+K again to collapse it.

Result: Quick Doc closes, but the cursor is now showing up on the next line. If you type any letter, the letter will show up where you set in step 2. That is, it goes to the correct location.
@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Jul 24, 2013 at 23:24 GMT

Raising it to medium priority since this has some confusing effect to Quick Edit and Quick Doc with incorrect line number with the following steps.

After step 4 if you set the cursor in any line below the actual cursor position and use Ctrl+E or Ctrl+K, both features are using the previous line instead of the current line. If you want to show inline color editor, then you need to set the cursor one line before where the color is located before you press Ctrl+E. If you set it to the actual location, then inline color editor wo't show up. If you try with Ctrl+K, then you always see the CSS property from the previous line in Quick Doc.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 24, 2013 at 23:42 GMT

@RaymondLim are you seeing this on today's new CEF? Or both?

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Jul 24, 2013 at 23:43 GMT

I'm seeing this on my win 7 even with sprint 25 build, but can't reproduce it on VM Win 8.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Jul 25, 2013 at 05:54 GMT

Update: Need to open main.css in default window size with Word Wrap on. Then when you open Quick Doc on margin property, the vertical scroll bar also shows up in main editor window and line 6 will be wrapped with an extra line. I believe this extra line is the culprit of the cursor showing on next line when closing Quick Doc.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Jul 25, 2013 at 09:06 GMT

@RaymondLim I'm UTR on Windows 7 with word wrap on and line 6 wrapped to an extra line.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Jul 25, 2013 at 17:48 GMT

I was able to repro with other steps too:

  1. Open main.css as above
  2. Put the cursor on margin (but don't bother with Quick Docs)
  3. Make the window just wide enough to not wrap -- the -webkit-linear-gradient line should be almost touching the edge.
  4. Resize the window up and down -- within the range that needs no vertical scrollbar

Result:
The -webkit-linear-gradient line will jump back and forth between wrapping and not wrapping, even though a vertical scrollbar never appears nor is needed.
Eventually (it may take a few seconds of resizing), the cursor will jump down to the next line (padding). But as soon as you type, the cursor jumps back up to the original line.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Jul 29, 2013 at 07:15 GMT

Nominating for Sprint 29 -- even if it's been around a couple sprints already, any bug where CodeMirror's state is this screwy seems like cause for concern...

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Thursday Aug 01, 2013 at 22:42 GMT

I think this might be the same problem as issue #4318.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Aug 01, 2013 at 23:11 GMT

@lkcampbell Yes, it is.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Aug 05, 2013 at 18:11 GMT

Reviewed. Assigned@RaymondLim since it seems related to #4572

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Aug 05, 2013 at 18:11 GMT

See also #4318

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Monday Aug 05, 2013 at 23:27 GMT

I don't think we can fix this one in Brackets since the cursor location is set from CodeMirror as it adjusts the wrapping for the vertical scrollbar. Sending back for review and suggesting to remove it from current sprint.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Aug 08, 2013 at 01:33 GMT

Seems not related to #4572 after all

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Aug 08, 2013 at 01:34 GMT

@RaymondLim@jasonsanjose@lkcampbell et al. -- could this be connected to either of these CodeMirror bugs?

codemirror/codemirror5#1642
codemirror/codemirror5#1123

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Thursday Aug 08, 2013 at 15:11 GMT

@peterflynn, I think it is very likely codemirror/codemirror5#1642 that we are seeing.

Are you thinking an update to Chrome 28.0.1500.95 might fix this issue? Or, rather, whatever CEF version corresponds to that Chrome version?

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Aug 08, 2013 at 18:30 GMT

@lkcampbell If that's true, then the new Chrome 29-based CEF we've been testing out will fix this. It's too late for this sprint, but hopefully it'll land next sprint.

@RaymondLim Do you want to test out this bug on the new CEF 1354 build? (NJ can give you a Mac build -- he made one for me yesterday; though for that matter, you could also test this on the older, crashy CEF 1337 build). If it's UTR, then we can tag this 'tracking' and remove it from the Sprint 29 milestone...

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Aug 08, 2013 at 19:02 GMT

This is a Windows only issue. So I'll wait on Jeff's changes to update to CEF 1354.

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Thursday Aug 08, 2013 at 19:08 GMT

@jasonsanjose Moving to Sprint 30 as it seems we need the new CEF for this one too.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Aug 08, 2013 at 20:09 GMT

This is still listed on the bug card--should we remove it?

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Aug 08, 2013 at 20:25 GMT

Yes, we should remove it.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Aug 09, 2013 at 20:23 GMT

Just tested with CEF 1354 build (Chromium 29) and still not fixed. So it may not be codemirror/codemirror5#1642 or codemirror/codemirror5#1123.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Tuesday Aug 13, 2013 at 16:49 GMT

Reviewed. To@njx.

@core-ai-bot
Copy link
Member Author

Comment by malayhm
Tuesday Aug 20, 2013 at 21:05 GMT

Chrome 29 is released today and the issued is fixed from chrome side.
https://code.google.com/p/chromium/issues/detail?id=246127

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Aug 20, 2013 at 22:32 GMT

I can't reproduce this on Mac even in Sprint 28, so maybe this is a Windows-only issue? I'll try it on my Windows machine next.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Tuesday Aug 20, 2013 at 22:44 GMT

Yes, this is Windows only issue and our current CEF still has the issue.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Aug 20, 2013 at 22:47 GMT

Ah. Yes, I can still reproduce it in current master on Windows.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Monday Aug 26, 2013 at 17:20 GMT

Reassigned to me.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 27, 2013 at 04:55 GMT

I'm trying to reproduce it in a simpler codemirror sample, but so far, no luck http://jasonsanjose.github.io/uploads/word-wrap-bug.html. Seems to only reproduce within the Brackets layout. I still have more angles to try.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 27, 2013 at 16:25 GMT

BTW,@njx@RaymondLim I can reproduce this on mac when the "show scrollbars" setting set to always.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Tuesday Aug 27, 2013 at 16:36 GMT

@jasonsanjose That makes sense as I was suspecting that the wrapping is triggered by the need to show the vertical scroll bar. Removing "Win Only" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot