[CLOSED] Tree context menu behaves unpredictably while naming new file

[core-ai-bot]

Issue by peterflynn
Wednesday Aug 07, 2013 at 19:25 GMT
Originally opened as adobe/brackets#4693

---

1. Right-click a folder > New File
2. Right-click the editable textfield where you'd type the filename
3. Choose one of the menu items there

Delete & Show in OS apply to the previously selected file -- so you can delete the wrong file by accident.

The other menu items finish creating the file, then do nothing (except for Refresh, which actually does refresh the tree after creating the new file).

To avoid confusion, we should probably just ignore right clicks and block the context menu from appearing while naming/renaming is in progress...

[core-ai-bot]

Comment by peterflynn
Wednesday Aug 07, 2013 at 19:28 GMT

---

This was originally reported via a blog comment

[core-ai-bot]

Comment by JeffryBooher
Thursday Aug 08, 2013 at 16:43 GMT

---

Actually, we should just finalize the rename on right click -- similar to #3720.

[core-ai-bot]

Comment by lkcampbell
Thursday Aug 29, 2013 at 04:57 GMT

---

I tested putting a listener on the context menu to force the rename to finish. It does work, but the behavior is a bit odd. The context menu appears and the rename is forced to finish, but then the renamed file receives focus and the context menu suddenly disappears.

This odd behavior is being caused by issue #1910. If we are going to use a forced rename finish as a solution, issue #1910 needs to be fixed first.

[core-ai-bot]

Comment by lkcampbell
Friday Aug 30, 2013 at 03:59 GMT

---

I tested my fix for this after applying my fix for issue #1910 and it works really well.

Once we get the #1910 fix merged, I will submit a pull request with a fix for this issue.

[core-ai-bot]

Comment by lkcampbell
Saturday Sep 07, 2013 at 03:36 GMT

---

@JeffryBooher, new pull request submitted. Fixes the merge conflicts.

[core-ai-bot]

Comment by JeffryBooher
Monday Sep 16, 2013 at 15:31 GMT

---

FBNC@peterflynn

[core-ai-bot]

Comment by JeffryBooher
Wednesday Oct 23, 2013 at 23:26 GMT

---

Sorry, forgot to assign this. @peterflynn please close.

[core-ai-bot]

Comment by peterflynn
Saturday Nov 16, 2013 at 01:31 GMT

---

@lkcampbell Since #1910 is fixed did you want to try doing the "nicer" version of this fix now? I'm still seeing the behavior where the context menu is visible briefly before the text-editing session terminates.

[core-ai-bot]

Comment by lkcampbell
Saturday Nov 16, 2013 at 04:17 GMT

---

@peterflynn, yeah I see it also. It might be that editor scroll event firing off again and closing all pop up windows. I will take a look at it this weekend.

[core-ai-bot]

Comment by lkcampbell
Thursday Apr 24, 2014 at 08:32 GMT

---

@peterflynn, finally getting back to this issue. I think the original issue filed here 9 months ago is not reproducible anymore. We still have an issue though. Now, when I right click, the rename is still forced, but instead of the context menu appearing, it briefly appears, then disappears.

I checked Sprint 32, which was about the time I submitted my original fix. In that Sprint I cannot reproduce the original issue nor the new issue. Since then, we introduced the animated drop down menus and I think this new issue is associated with the animated menus.

Looking for input on next steps. I suggest you try to reproduce this issue using your original steps and, if you cannot, we close this issue as fixed. Then, I can file a new issue on the "appear then disappear" menu problem and I can work on fixing that issue.

[core-ai-bot]

Comment by ingorichter
Tuesday Sep 16, 2014 at 00:51 GMT

---

In the new file tree/ProjectManager implementation it's working differently. Right click in the edit field will abort the create operation and show the context menu. Now you can select any operation from the context menu, which result in an error for some operations.

[core-ai-bot]

Comment by dangoor
Friday Sep 19, 2014 at 15:02 GMT

---

I'll fix this because it shouldn't be misbehaving like that. Should be a quick fix.

[core-ai-bot]

Comment by RaymondLim
Wednesday Oct 01, 2014 at 20:57 GMT

---

This is fixed in release 44. We're now finalizing renaming if you right click in the input field. Closing.