[CLOSED] Spanish strings for Sprint 33 #5204
Comments
|
Done with the review. Did this included the Sprint 32 string updates? By the index, it seems like it does, but not sure if there were any string changes lately. |
|
Hey, This should include all the string changes up to sprint 33, since I use the localization extension to compare the spanish locale with the root one ;) |
|
Great. Does that tool also checks for English string changes and not just additions and deletions? |
|
No, currently it just does static compare between the current state of the files but knows nothing about the history of the strings... that's a great idea worth exploring though ;) |
|
I was doing diff checks between the latest root string.js and the one at which the es strings was at. In this case the Sprint 32 strings: http://diffchecker.com/r3xa0z8u It seem like only LIVE_DEV_NEED_HTML_MESSAGE needs a string update. |
|
Updated and pushed. Good catch! (I'll see next week if I can use the git extension somehow to diff the changes in the root strings up to a point to detect these cases...) Also, I was thinking about translating brackets-update as well. Would you be up to review those as well starting next sprint? |
|
That would be great. And yes, I can review those too. Is it too late for this sprint? One final comment before ready to merge. |
|
Ok, I've forced pushed your last comment, so this should be good to go :) (I'll be sending you the brackets-updates translations for this sprint shortly) |
|
Great. Merging :) |
Thursday Oct 24, 2013 at 21:32 GMT
Originally opened as adobe/brackets#5676
Updated spanish strings and getting started up to sprint 33.
@TomMalbran Care to review?jbalsas included the following code: https://github.com/adobe/brackets/pull/5676/commits
The text was updated successfully, but these errors were encountered: