Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Added Haskell as a language #9533

Open
core-ai-bot opened this issue Aug 30, 2021 · 7 comments
Open

[CLOSED] Added Haskell as a language #9533

core-ai-bot opened this issue Aug 30, 2021 · 7 comments

Comments

@core-ai-bot
Copy link
Member

Issue by VenessaJohansenBarrera
Tuesday Apr 07, 2015 at 18:38 GMT
Originally opened as adobe/brackets#10844


Added at the end of the languages.json file so that Haskell will have
syntax highlighting in Brackets.


VenessaJohansenBarrera included the following code: https://github.com/adobe/brackets/pull/10844/commits

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Apr 08, 2015 at 05:05 GMT


@VenessaJohansenBarrera We need you to sign the Brackets contributor agreement (CLA) before we can merge this.

@core-ai-bot
Copy link
Member Author

Comment by VenessaJohansenBarrera
Wednesday Apr 08, 2015 at 13:03 GMT


The agreement has been signed.

Thanks!
On Apr 8, 2015 1:06 AM, "Peter Flynn" notifications@github.com wrote:

@VenessaJohansenBarrera https://github.com/VenessaJohansenBarrera We
need you to sign the Brackets contributor agreement (CLA)
http://dev.brackets.io/brackets-contributor-license-agreement.html
before we can merge this.


Reply to this email directly or view it on GitHub
adobe/brackets#10844 (comment).

@core-ai-bot
Copy link
Member Author

Comment by abose
Monday Apr 13, 2015 at 17:27 GMT


validated change, merging.@VenessaJohansenBarrera Thanks!

@core-ai-bot
Copy link
Member Author

Comment by busykai
Monday Apr 13, 2015 at 20:07 GMT


as Brackets is the editor for the web, Haskell should rather not be part of the core. there's a syntax highlighting extension for Haskell, readily available via registry. there are many languages which are intentionally not part of Brackets, but still available as extensions. why Haskell has been made an exception?

@core-ai-bot
Copy link
Member Author

Comment by abose
Tuesday Apr 14, 2015 at 05:55 GMT


This change only brings in the file extension awareness in brackets and very basic comment block awareness for haskell, similar to the way we have basic support for c/c++/java... which are not primarily 'web' langs. Full blown support is not part of brackets as said.

@core-ai-bot
Copy link
Member Author

Comment by busykai
Monday Apr 20, 2015 at 00:57 GMT


@abose, I'm sorry for being stubborn, but this deserves some more discussion. I am pretty sure I understand what this PR does (exactly what the corresponding would do). We also could have support for Cobol, Pascal, Fortran etc., but we did not add these before. I would understand including these if there were no extensibility, but I'd much rather add support for these via extensions. Now, that's my personal preferences... I guess from the product standpoint, we just have to be consistent add all of them or only those which are relevant to web development. Strong focus on web is what makes Brackets so great. Having these irrelevant languages floating around would only create false expectations on the customer side and steals time from development.

Usability-wise, we have a drop-down box to pick a language in the editor status bar. I'd rather not contaminate that list with arbitrary languages (it's long enough already). Those who need support for extra languages have extensions at their disposal.

Just my couple of cents.

@core-ai-bot
Copy link
Member Author

Comment by abose
Monday Apr 20, 2015 at 06:58 GMT


I see your point@busykai , and now that i think of it , i agree with you. Haskell is still an obscure language (compared to c/c++/etc.. in our language dropdown), so supporting that is best left to the extensions as they could give in much more support for those languages than the basic support. If no one objects, i could revert the commit by wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant