[CLOSED] [CEF 2171][Linux only] Upgrade Linux app-shell's to use CEF 2171

[core-ai-bot]

Issue by nethip
Monday May 04, 2015 at 08:10 GMT
Originally opened as adobe/brackets#11047

---

Upgrade app-shell CEF version to 2171 on Linux. I am creating this placeholder card to track the following issues.

adobe/brackets#4611
adobe/brackets#10231
adobe/brackets-shell#503
adobe/brackets-shell#501
adobe/brackets-shell#499
adobe/brackets-shell#458
adobe/brackets-shell#483
adobe/brackets-shell#491
adobe/brackets#10255

All of these issues are related to upgrading CEF on linux to 2171

[core-ai-bot]

Comment by FriendOfFatBeagle
Friday Jun 12, 2015 at 10:14 GMT

---

I have this problem here:
adobe/brackets#11161

Why not make the extension manager dialog box as part of a tab view?

[core-ai-bot]

Comment by Fordi
Monday Jun 29, 2015 at 14:31 GMT

---

I'd like to help.

On Windows, brackets was my primary non-IDE editor for a long while, and I'd like to go back to using it now I'm on a linux box. The lack of command-line control and preservation of basic state is essentially what's preventing me from making the switch from Geany. If I can help clear this migration, I'll fork, do the thing, and create a pull request appropriately.

Can you (nethip or rroshan1) comment as to the set of issues regarding migration to CEF 2171, as well as any ancillary concerns you have? I'd like to avoid re-analyzing the problem where it might have already been sussed, and to have a fair idea of what you want to accomplish that's not implied with the basic CEF upgrade.

[core-ai-bot]

Comment by nethip
Monday Jun 29, 2015 at 18:01 GMT

---

@Fordi We really appreciate your help on this!

About the issue; After upgrading to CEF 2171 on Linux, we are getting intermittent crashes while quitting. Just launch brackets with CEF 2171 and then quit and you should see the crash in the terminal. We spent some time on this with our own theories 😄 but did not land with a clean solution. brackets-shell, a thin wrapper around CEF, is based out of cefclient, the sample app packaged as part of CEF. We are currently using the code from cefclient that was packaged as part of older version of CEF. My guess is, we have not moved our code to latest version of cefclient. So carefully examining all the methods of cefclient, which is based out of CEF 2171 and comparing that with brackets-shell should lead us somewhere. If I were you, I would probably start fresh by taking cefclient as a base and would start adding brackets-shell code piece by piece to nail the problem. But that's just me. Maybe there is a better way to figure out the issue and fix it. By the way all of the work in happening on this branch jasonsanjose/cef_2171_linux in brackets-shell repository. Do let me know if you require any more information on this. Thanks!

[core-ai-bot]

Comment by ficristo
Tuesday Sep 26, 2017 at 18:24 GMT

---

Fixed. See adobe/brackets-shell#619