Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <div> and <span> wrappers around edits #117

Open
frostyweather opened this issue Apr 13, 2016 · 9 comments
Open

Add <div> and <span> wrappers around edits #117

frostyweather opened this issue Apr 13, 2016 · 9 comments

Comments

@frostyweather
Copy link
Collaborator

Add <div> and <span> wrappers around the edits to style these chunks of text differently than the rest of the book. Just letting you know, @FullCreamMilkMan.

@FullCreamMilkMan
Copy link
Collaborator

Hi. Sure, OK. Do you have particular edits in mind, or just generally? Could you show me, so I know exactly what you mean? Thanks, @frostyweather.

@frostyweather
Copy link
Collaborator Author

Sure thing @FullCreamMilkMan! Basically all I am doing is removing the double brackets [[]] and replacing those with <div class="editor"> for the remarks that are their own paragraph or <span class="editor"> for the double brackets within a paragraph. I am not changing any of the edit material, just changing the styling of how they look on the page. For example:

I am changing this:

[[*Ed: Is "custom-tailored" like belt and braces? We can ditch "custom-" as "tailored" can do all the work.*]]

To this:

<div class="editor">
{% capture m %}
Ed: Is "custom-tailored" like belt and braces? We can ditch "custom-" as "tailored" can do all the work.
{% endcapture %}
{{ m | markdownify }}
</div>

I am doing this to basically give all of your edits a class name so I can turn the text red or give it a highlighted look to differentiate it from the actual content of the book. Sound good?

screen shot 2016-04-13 at 10 02 07 am

@FullCreamMilkMan
Copy link
Collaborator

Yeah, that's fine. When Brad has finished chapter 5, do you want me to wrap my edits like this, or can I leave that to you?

@FullCreamMilkMan
Copy link
Collaborator

Oh, and there are a couple of edits which I deliberately marked up so they remain hidden. Have you identified them? They're early on, I think, and only once or twice. They should stay hidden, though I can discuss that with Brad.

@frostyweather
Copy link
Collaborator Author

@FullCreamMilkMan You can leave that to me if it is easier doing it the other way. I made the invisible ones visible I believe. Probably a good question to ask @bradfrost whether he wants these hidden or not.

@frostyweather
Copy link
Collaborator Author

@FullCreamMilkMan Also, I created a new branch for this called edits-ian so we can always compare and contrast with the edits branch in case we do want to go back to the invisible state.

@FullCreamMilkMan
Copy link
Collaborator

I'll keep using the square braces for now – it'll be much easier for me and won't slow me down while editing. Hope that's OK. Thanks for setting up a new branch for your work. That'll keep things nice and neat, and like you say we can revert back as and when necessary. Great.

Now I can start to get nervous as my usually unseen work prepares for the light of day!

@frostyweather
Copy link
Collaborator Author

@FullCreamMilkMan Sounds good. That works for me. Your work will look great! haha

@bradfrost
Copy link
Owner

@FullCreamMilkMan @frostyweather

Oh, and there are a couple of edits which I deliberately marked up so they remain hidden. Have you identified them? They're early on, I think, and only once or twice. They should stay hidden, though I can discuss that with Brad.

If you feel like those should be hidden then we can do that. I'd ask why they're hidden (are you calling me ugly?) but if you feel strongly about keeping a few comments private, that's totally fine.

Now I can start to get nervous as my usually unseen work prepares for the light of day!

Hahaha it'll be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants