Titlise column verbose_name when derived from model #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Any verbose_name that was not passed explicitly in the column | ||
| definition is returned titlised in keeping with the Django convention | ||
| of verbose_names being defined in lowercase and uppercased/titlised | ||
| as needed by the application. |
There was a problem hiding this comment.
Can you add backticks around variable/property names here? i.e.: verbose_names -> verbose_names
|
Apart from some line comments I added, it looks really good, thanks! Will merge after you work on those. |
|
I updated the docstring with backticks per your note, and tried to simplify the booleancolumn but it failed a test with my change. See the linenote for details. Let me know if I can do anything else here. |
|
I'll merge when you revert the |
|
Sorry about that, I thought I fixed that in a commit --amend after I caught the test failure. Reverted. |
|
Merged, thanks! |
jieter
added a commit
that referenced
this pull request
Sep 9, 2016
This was referenced Jan 18, 2017
This was referenced Oct 10, 2017
This was referenced Oct 30, 2017
This was referenced Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at #249 and #368. If the verbose_name of a model is used to generate the verbose_name of the column, it is titlised. If the verbose_name is passed directly from a Column, it is used verbatim (see the test_column_verbose_name "override" tests). I updated the existing tests to reflect this change and added a couple new tests as well. If there's anything that I overlooked or need to change for this to be acceptable please let me know.