Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #399 #400

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Fix for #399 #400

merged 1 commit into from
Dec 21, 2016

Conversation

dyve
Copy link
Contributor

@dyve dyve commented Dec 21, 2016

Remove overwritten columns from base-columns, add test for behavior.

@jieter
Copy link
Owner

jieter commented Dec 21, 2016

Looks good, merging. Would be nice if you could document this behaviour somewhere.

Thanks!

@jieter jieter merged commit d8df96d into jieter:master Dec 21, 2016
@dyve
Copy link
Contributor Author

dyve commented Dec 21, 2016

New PR with documentation (#401)

jieter pushed a commit that referenced this pull request Dec 21, 2016
* Non-column attributes on child class overwrite column attributes of parent class (fix #399)

* Fix and add to FAQ for #399.
intiocean pushed a commit to intiocean/django-tables2 that referenced this pull request Feb 27, 2017
intiocean pushed a commit to intiocean/django-tables2 that referenced this pull request Feb 27, 2017
* Non-column attributes on child class overwrite column attributes of parent class (fix jieter#399)

* Fix and add to FAQ for jieter#399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants