Fix 'title' template filter #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue jieter#438 and make the filter work more correctly with non unicode letters)
jieter
requested changes
May 15, 2017
| title = keep_lazy_text(title) | ||
| except ImportError: | ||
| from django.utils.functional import lazy | ||
| title = lazy(title, six.text_type) |
There was a problem hiding this comment.
Please add a comment for what version of Django this shim can be removed.
| return ' '.join([ | ||
| any([c.isupper() or c.isdigit() for c in w]) and w or old_title(w) | ||
| for w in value.split() | ||
| ]) |
There was a problem hiding this comment.
Can you elaborate on the performance implementation vs the old one?
There was a problem hiding this comment.
Python 2.7.6, django 1.10.7
There was a problem hiding this comment.
looks good!
I guess the lazyness will add a bit of overhead too, but since django is littered with lazy evaluation, it should not be too much.
There was a problem hiding this comment.
same with keep_lazy_text decorator
jieter
added a commit
that referenced
this pull request
May 15, 2017
|
@ygwain merged, thanks! |
|
released 1.7.0 |
This was referenced Jun 1, 2017
|
cool, thnx
…On Thu, Jun 1, 2017 at 10:48 AM, Jan Pieter Waagmeester < ***@***.***> wrote:
released 1.7.0 <https://pypi.python.org/pypi/django-tables2/1.7.0>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#443 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB1UJg8jT09IkqcHTaL8fE0qXE61f906ks5r_mzdgaJpZM4NaZ2Y>
.
|
This was referenced Oct 2, 2017
This was referenced Oct 10, 2017
This was referenced Oct 30, 2017
This was referenced Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #438 and make the filter work more correctly with non unicode letters)