302 Found

[phylake]

I'm hitting this error message

ghinstallation/transport.go

Line 226 in 97b6ed0

e.Message = fmt.Sprintf("received non 2xx response status %q when fetching %v", resp.Status, req.URL)

where resp.Status is 302 Found

Shouldn't this redirect have been followed?

[bradleyfalzon]

Yeah with the default client, it should follow 10 redirects https://pkg.go.dev/net/http#Client, and if this fails should return an error https://cs.opensource.google/go/go/+/refs/tags/go1.20.3:src/net/http/client.go;l=804

Is your client overwriting this behaviour? If there's more than 10 redirects, we should have checked and returned that error.

[phylake]

No it shouldn't be. I have roughly this

import (
	"net/http"
	"github.com/bradleyfalzon/ghinstallation/v2"
	"github.com/google/go-github/v50/github"
)

const (
	GHEUrl = "https://my-enterprise-endpoint.com"
	ClientId = 1
	InstallationId = 2
	PKPath = "/path/to/app-private-key.pem"
)

func main() {
	transport, _ := ghinstallation.NewKeyFromFile(http.DefaultTransport, ClientId, InstallationId, PKPath)
	transport.BaseURL = GHEUrl

	httpClient := &http.Client{
		Transport: transport,
	}

	ghClient, _ := github.NewEnterpriseClient(GHEUrl, GHEUrl, httpClient)
	
	// ...
}

The default client is just var DefaultClient = &Client{}

[phylake]

Oh it's a redirect to /login?return_to=...

[phylake]

I needed to append /api/v3. I didn't because the go-github docs said it would be appended
https://pkg.go.dev/github.com/google/go-github/v50/github#NewEnterpriseClient