Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color conversion algo's #3

Open
bobbyduhbrain opened this issue Dec 14, 2013 · 3 comments
Open

Color conversion algo's #3

bobbyduhbrain opened this issue Dec 14, 2013 · 3 comments

Comments

@bobbyduhbrain
Copy link
Collaborator

Here is a list of them:

http://www.cs.rit.edu/~ncs/color/t_convert.html

@bobbyduhbrain
Copy link
Collaborator Author

After further thinking about it, color conversion should happen in the form of setters for the lights. Since you can set xy, ct, and hue/saturation, it would make sense to me to add the methods to lights class:

def set_xy(r,g,b)

def set_ct(r,g,b)

def set_hsl(r,g,b)

The methods should take RGB since, imo, most programmers are using RGB when they're thinking about colors. Of course, I am open to discussion, that's just my thoughts on it.

@bobbyduhbrain
Copy link
Collaborator Author

Oh...and should conversion happen inside these methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants