Use run-mode-hooks to trigger extra major-mode hooks
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `define-derived-mode` to declare the `dart-mode`, there is a function to setup the mode manually. This causes other packages to not be able to detect major mode changes, as the `change-major-mode-after-body-hook` and `after-change-major-mode-hook` are not being triggered. This PR replaces `run-hooks` with `run-mode-hooks` to trigger the extra hooks when changing a major mode. ### Similar to: - syl20bnr/spacemacs#7111 - skeeto/elfeed#214 - Fixes syl20bnr/spacemacs#8333
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Sep 4, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Sep 4, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Sep 4, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Sep 4, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Sep 4, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Sep 4, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
|
Looking at the test failures, this seems to be related with #35 but works for Dart stable |
|
@bltavares the project now uses |
|
Closed as issue may be resolved, and it's not clear to me how to reproduce. |
|
Hi there @bradyt. Using Thank you. |
|
Great, thank you for confirming! |
bltavares
added a commit
to bltavares/spacemacs
that referenced
this pull request
Dec 17, 2018
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
duianto
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Apr 12, 2019
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves #8333 - Resolves #8395 - Resolves #10452 --- [previous implementation]: #8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
billy1kaplan
pushed a commit
to billy1kaplan/spacemacs
that referenced
this pull request
Apr 19, 2019
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
thomasheartman
pushed a commit
to thomasheartman/.emacs.d
that referenced
this pull request
Jul 6, 2019
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr/spacemacs#8333 - Resolves syl20bnr/spacemacs#8395 - Resolves syl20bnr/spacemacs#10452 --- [previous implementation]: syl20bnr/spacemacs#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
stephanschubert
pushed a commit
to stephanschubert/spacemacs
that referenced
this pull request
Oct 23, 2019
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
sei40kr
pushed a commit
to sei40kr/spacemacs
that referenced
this pull request
Nov 11, 2019
This is a initial implementation of a Dart later. A [previous implementation] has been deprecated, using a forked version of `dart-mode`. This layer uses the [dart-mode] linked on the [Dart tools] page. The layer works with a Flutter installation as well. Ideally, we would be able to offer a `lsp` backend as an option to use, instead of using the Dart Analyzer, but I'm still figuring out how to implement and integrate this. This layer has [some] [fixes] to make it work, and it is waiting for upstream to take patches. - Resolves syl20bnr#8333 - Resolves syl20bnr#8395 - Resolves syl20bnr#10452 --- [previous implementation]: syl20bnr#8406 [dart-mode]: https://github.com/bradyt/dart-mode [Dart tools]: https://www.dartlang.org/tools [some]: emacsorphanage/dart-mode#67 [fixes]: emacsorphanage/dart-mode#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
define-derived-modeto declare thedart-mode, there is a function to setup the mode manually.This causes other packages to not be able to detect major mode changes, as the
change-major-mode-after-body-hookandafter-change-major-mode-hookare not being triggered.This PR replaces
run-hookswithrun-mode-hooksto trigger the extra hooks when changing a major mode.Similar to: