Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the parser is responsible for parsing the patch #12

Closed
mitar opened this issue Oct 30, 2019 · 5 comments
Closed

Clarify that the parser is responsible for parsing the patch #12

mitar opened this issue Oct 30, 2019 · 5 comments

Comments

@mitar
Copy link
Member

mitar commented Oct 30, 2019

It seems = has special meaning? Can selector contain such string?

@toomim
Copy link
Member

toomim commented Oct 30, 2019

Yes. But we should clarify that in the spec. This should be totally parseable:

["="] = 3

In practice, the Parser (aka selector) implementation will be responsible for parsing a braid-patch. It'll have to make sure that the grammar it defines for indexing is unambiguous.

@toomim toomim closed this as completed Oct 30, 2019
@mitar
Copy link
Member Author

mitar commented Oct 30, 2019

Not sure what is your policy about closing issues, but shouldn't they be closed once things are merged in, or decided that they will not be done? Above you mention that you agree this should be clarified, but then closed the issue? So should it be clarified or not?

Hm, every parser will have to parse the whole patch? That is an interesting design decision.

@mitar mitar reopened this Oct 30, 2019
@toomim
Copy link
Member

toomim commented Oct 30, 2019

Oh, I closed it because the subject of this issue is a question, which was answered.

But sure, let's change the subject to "Clarify that the parser is responsible for parsing the patch."

@toomim toomim changed the title Can selector contain string " = " Clarify that the parser is responsible for parsing the patch Oct 30, 2019
@mitar
Copy link
Member Author

mitar commented Oct 30, 2019

From #13, we should also clarify that parser also has to define how portals are to be specified for that parser type.

@mitar
Copy link
Member Author

mitar commented Nov 1, 2019

This is not applicable anymore because now everything is parsed through the HTTP stack itself.

@mitar mitar closed this as completed Nov 1, 2019
@mitar mitar added wontfix and removed actionable labels Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants