Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/58 unittests ci #246

Merged
merged 10 commits into from Aug 25, 2020
Merged

Feature/58 unittests ci #246

merged 10 commits into from Aug 25, 2020

Conversation

zuevval
Copy link
Member

@zuevval zuevval commented Aug 25, 2020 •
edited

Partially solved #58

  • moved some tests from androidTest to test, so they may be run without AVD
  • fixed gradlew (https://stackoverflow.com/a/53943650)
  • merged dev
  • added bage to README: Actions Status (of course it shows FAILING because reflects main repo CI status)

@winter-yuki
Copy link
Member

I've merged dev into the ci branch. Can you please recreate PR to have proper diff?

@zuevval
Copy link
Member Author

zuevval commented Aug 25, 2020

I've merged ci into this branch in turn, so the diff is proper now

@winter-yuki
Copy link
Member

Very good job

@winter-yuki winter-yuki merged commit 1a8d28a into braille-systems:ci Aug 25, 2020
@zuevval
Copy link
Member Author

zuevval commented Aug 25, 2020

by the way, I have no idea why diff is proper in _KotlinTest.kt which I copied and pasted with Ctrl+C -> Ctrl+V and not so smart in other tests which I moved with AndroidStudio's drag-and-drop interface.

@zuevval zuevval deleted the feature/58-unittests-ci branch August 26, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@winter-yuki winter-yuki

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zuevval @winter-yuki