Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

children of block "listList" are missing a surrounding ul-tag #366

Closed
n0-m4d opened this issue Apr 23, 2015 · 2 comments
Closed

children of block "listList" are missing a surrounding ul-tag #366

n0-m4d opened this issue Apr 23, 2015 · 2 comments

Comments

@n0-m4d
Copy link

n0-m4d commented Apr 23, 2015

hi.

when rendering a menu like

  • product
    • category1
      • category2

the second level menu (category2) is missing a surrounding ul tag.

i assume this is a bug which can be fixed by modifying

{% block listList %}
{% spaceless %}
    {% if item.hasChildren and options.depth is not sameas(0) and item.displayChildren %}
        {{ block('children') }}
    {% endif %}
{% endspaceless %}
{% endblock listList %}

to

{% block listList %}
{% spaceless %}
    {% if item.hasChildren and options.depth is not sameas(0) and item.displayChildren %}       
       <ul{{ _self.attributes(listAttributes) }}>
            {{ block('children') }}
       </ul>
    {% endif %}
{% endspaceless %}
{% endblock listList %}
@ocetnik
Copy link
Contributor

ocetnik commented Apr 26, 2015

I added it. It's working correctly?

@n0-m4d
Copy link
Author

n0-m4d commented Apr 27, 2015

yep, perfect!

@n0-m4d n0-m4d closed this as completed Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants