Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove start_offset_samples and stop_offset_samples argument in create_fixed_length_windows #269

Closed
gemeinl opened this issue Jun 23, 2021 · 0 comments · Fixed by #275
Closed
Assignees

Comments

@gemeinl
Copy link
Collaborator

gemeinl commented Jun 23, 2021

Instead or renaming the arguments as discussed in #260, we realized that these arguments do not make sense at all in the setting of create_fixed_length_windows. There, these arguments are equivalent to applying a preprocessing step that crops the signals in advance. We hence aim to remove the arguments at some point and deprecate them for now.

@gemeinl gemeinl changed the title Remove start_offset_samples and stop_offset_samples argument in create_fixed_length_windows Remove start_offset_samples and stop_offset_samples argument in create_fixed_length_windows Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants