New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of ATCnet #429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 84.81% 85.40% +0.59%
==========================================
Files 48 49 +1
Lines 3728 3913 +185
==========================================
+ Hits 3162 3342 +180
- Misses 566 571 +5 |
ping @tomMoral @agramfort :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I would make all classes in ATCNet.py with a starting _ to be private except the ATCNet class that is public.
Co-authored-by: robintibor <robintibor@gmail.com>
Thanks Alex! I didn't add the _ in some modules because I thought those were general enough to be useful in other future networks. I reckon I should have moved them into |
Feel free to merge if it looks good to you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just one nitpick but this is on me, I don't like the warpping style when subclassing does the job. feel free to ignore.
Same can be done with the maxnorm layer. |
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Good point! Did the same for |
No description provided.