Pin skorch version to below 0.14 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated environment.yml and requirements.txt to pin skorch package version to less than 0.14. This change ensures compatibility with existing code which may not support the latest version of skorch. For example it expects classifiers like EEGClassifier to have the 'classes_inferred' attribute.
bruAristimunha
approved these changes
Aug 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 59 59
Lines 4267 4267
=======================================
Hits 3590 3590
Misses 677 677 |
|
Thank you so much @ZamboniMarco99 :) nice first PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #462