MNT Improve the GitHub Actions #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 84.41% 83.52% -0.90%
==========================================
Files 60 60
Lines 4357 4388 +31
==========================================
- Hits 3678 3665 -13
- Misses 679 723 +44 |
agramfort
approved these changes
Aug 31, 2023
|
Sorry @agramfort, I didn't notice that you had already approved. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #471, #464 and a lot of headaches. We are having a small crisis with version management of the libraries we depend on. It's been an unexpected journey, a little inconvenient and irritating to deal with.
From the beginning, we realized that the workflow was broken at the conda step. We switched to Mamba in PR #461, and Mamba managed to solve it.
After that, we get an extra mandatory skorch parameter without any clear explanation. I tried to find the root of the problem in skorch, but since we didn't notice it right away, git blame doesn't point to the root (related with skorch-dev/skorch#1016). The change was not intentional on the skorch side. I couldn't solve it, and consequently, we now have the
classesparameter in our EEGClassifier.After that, outside of CI, we noticed that some acceptance tests broke. The training curves generated were different from what was expected in the tests, which should not happen. During this investigation process, I realized that this only affects Python versions other than 3.7, but since our CI was only configured on Python 3.7, I don't know how long we've had this error.
After that, I opened this PR to try to improve Git Action and try to resolve everything related.
I will need a beer after this, hahah
Explaining a little the PR and why I am changing a lot of stuffs @agramfort and @robintibor.