Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise models BCI #488

Merged
merged 73 commits into from Sep 7, 2023
Merged

Conversation

PierreGtch
Copy link
Collaborator

cf #457

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #488 (1d53fca) into master (0f72195) will increase coverage by 0.29%.
Report is 1 commits behind head on master.
The diff coverage is 98.05%.

❗ Current head 1d53fca differs from pull request most recent head f4877ef. Consider uploading reports for the commit f4877ef to get more accurate results

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   83.50%   83.79%   +0.29%     
==========================================
  Files          60       61       +1     
  Lines        4426     4518      +92     
==========================================
+ Hits         3696     3786      +90     
- Misses        730      732       +2     

braindecode/models/base.py Outdated Show resolved Hide resolved
braindecode/models/base.py Outdated Show resolved Hide resolved
braindecode/models/base.py Outdated Show resolved Hide resolved
test/unit_tests/models/test_base.py Outdated Show resolved Hide resolved
@bruAristimunha bruAristimunha changed the title Normalise models Normalise models BCI Sep 5, 2023
docs/whats_new.rst Outdated Show resolved Hide resolved
bruAristimunha and others added 3 commits September 5, 2023 15:13
Co-authored-by: robintibor <robintibor@gmail.com>
Co-authored-by: robintibor <robintibor@gmail.com>
@cedricrommel
Copy link
Collaborator

LGTM. I checked the main EEGModuleMixin class, the deprecation function and 3-4 classes adaptations (not all of them).

@PierreGtch PierreGtch marked this pull request as ready for review September 6, 2023 19:40
@PierreGtch
Copy link
Collaborator Author

@robintibor @agramfort @bruAristimunha what do you think about replacing the model param ch_names by chs_info (a list of dict)? So that we can pass all the information available in epochs.info[‘chs’] to the model.

@robintibor robintibor merged commit f054d46 into braindecode:master Sep 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants