Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fixing conda environment and installation in tests #505

Merged
merged 22 commits into from
Sep 7, 2023

Conversation

sylvchev
Copy link
Collaborator

@sylvchev sylvchev commented Sep 6, 2023

This PR aims at solving dependencies issues with conda and requirements files. Issues with poetry will be addressed in another PR.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #505 (2d2b60c) into master (25f65b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   83.81%   83.81%           
=======================================
  Files          61       61           
  Lines        4524     4524           
=======================================
  Hits         3792     3792           
  Misses        732      732           

@sylvchev
Copy link
Collaborator Author

sylvchev commented Sep 6, 2023

Removed conda environment that was taking too long to install due to dependencies resolution (between 5 minutes to never ending).
The pip setup.py file is updated, as long with the CI. We could use pip install -e .[moabb,docs,tests] now.

setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bruAristimunha bruAristimunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @sylvchev, can you please update the whats_new file and the documentation?

@sylvchev
Copy link
Collaborator Author

sylvchev commented Sep 7, 2023

LGTM @bruAristimunha !

@bruAristimunha bruAristimunha merged commit a04699e into braindecode:master Sep 7, 2023
15 checks passed
@bruAristimunha bruAristimunha changed the title Fixing conda environment and installation in tests DOC Fixing conda environment and installation in tests Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants