Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC First commit for python tutorial #523

Merged
merged 9 commits into from
Sep 10, 2023

Conversation

remidbs
Copy link
Contributor

@remidbs remidbs commented Sep 8, 2023

Added a pure torch version of the train/test tutorial.

Most of the data loading and preprocessing is similar, main differences are the two last paragraph showcasing a torch training loop and an equivalent pytorch lightning loop.

@remidbs
Copy link
Contributor Author

remidbs commented Sep 8, 2023

cc @bruAristimunha

Feel free to build on this and change as many things as you think is relevant!
I'll also need your stamp for triggering the workflows

@bruAristimunha
Copy link
Collaborator

bruAristimunha commented Sep 8, 2023

Triggered ;) @remidbs

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #523 (0160d3c) into master (82c412b) will not change coverage.
The diff coverage is n/a.

❗ Current head 0160d3c differs from pull request most recent head c1ea803. Consider uploading reports for the commit c1ea803 to get more accurate results

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          63       63           
  Lines        4578     4578           
=======================================
  Hits         3862     3862           
  Misses        716      716           

@bruAristimunha bruAristimunha marked this pull request as ready for review September 10, 2023 15:24
@remidbs
Copy link
Contributor Author

remidbs commented Sep 10, 2023

Thanks for these nice edits!

Just did tiny edits, otherwise LGTM :)

I also added you as an author now that you built on this.

I'll need your workflow approval to ensure I didn't break any CI job.

@bruAristimunha bruAristimunha merged commit 74d5ffe into braindecode:master Sep 10, 2023
12 of 13 checks passed
@bruAristimunha
Copy link
Collaborator

bruAristimunha commented Sep 10, 2023

Thank you so much @remidbs!

Once the CI has been updated, you can check out your tutorial on the braindecode dev page.

Congratulations on your first PR on braindecode ;) Feel invited to always contribute to braindecode!

Please let me know if there is any way to do more cross-over between what you are working on and the braindecode (maybe another biosignal). I'm super interested in having you on board!

dcwil pushed a commit to dcwil/braindecode that referenced this pull request Sep 11, 2023
* First commit for python tutorial

* added lightning dependency to doc

* First iteration

* Second iteration

* Updating docs

* Typos + use `disable=` in tqdm

* Add Bruno in authors

---------

Co-authored-by: bruAristimunha <a.bruno@aluno.ufabc.edu.br>
@bruAristimunha bruAristimunha changed the title First commit for python tutorial DOC First commit for python tutorial Sep 11, 2023
@remidbs
Copy link
Contributor Author

remidbs commented Sep 11, 2023

Thank you! pleasure to collaborate! looking forward to the next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants