Models dict #524
Merged
Models dict #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 84.37% 84.35% -0.02%
==========================================
Files 63 63
Lines 4545 4578 +33
==========================================
+ Hits 3835 3862 +27
- Misses 710 716 +6 |
|
Can you explain a bit what this does? And maybe add such explanation in the comments. Looks quite magic to me at the moment haha :) |
bruAristimunha
approved these changes
Sep 10, 2023
|
I added a small comment explaining the filling logic @robintibor. It is a for that is executed when loading the library that will allow you to access the list of models and is updated dynamically. |
|
@robintibor Haha it’s the same as for the |
|
Thank you Pierre! |
dcwil
pushed a commit
to dcwil/braindecode
that referenced
this pull request
Sep 11, 2023
* Add models_dict * Add test for models_dict * Update whats_new.rst * Update braindecode/models/util.py * flake8 --------- Co-authored-by: Bru <a.bruno@aluno.ufabc.edu.br>
dcwil
added a commit
to dcwil/braindecode
that referenced
this pull request
Sep 11, 2023
dcwil
added a commit
to dcwil/braindecode
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
braindecode.models.util.models_dict