Allow passing only model name #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 84.48% 84.51% +0.03%
==========================================
Files 63 63
Lines 4653 4664 +11
==========================================
+ Hits 3931 3942 +11
Misses 722 722 |
bruAristimunha
approved these changes
Sep 11, 2023
|
Hey, Can you create one test and update the whats_new file @PierreGtch? |
|
@bruAristimunha yes I'm just waiting to merge #517 to put the tests in |
sliwy
approved these changes
Sep 11, 2023
|
@bruAristimunha Ready to merge |
|
Thank you @PierreGtch and @sliwy ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing only the name of a braindecode model to
_EEGNNeuralNetwork.This is easy to implement and facilitates the usage of config files.
#457