Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log accuracy score in EEGClassifier #541

Merged
merged 11 commits into from Sep 27, 2023

Conversation

PierreGtch
Copy link
Collaborator

@PierreGtch PierreGtch commented Sep 19, 2023

closes #510 closes #521

@PierreGtch PierreGtch marked this pull request as ready for review September 19, 2023 13:51
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #541 (c62811b) into master (cb5cad0) will increase coverage by 0.19%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   84.55%   84.75%   +0.19%     
==========================================
  Files          63       63              
  Lines        4676     4749      +73     
==========================================
+ Hits         3954     4025      +71     
- Misses        722      724       +2     

@bruAristimunha
Copy link
Collaborator

is there somewhere missing?

@PierreGtch
Copy link
Collaborator Author

@bruAristimunha all good to merge

@bruAristimunha
Copy link
Collaborator

Thank you @PierreGtch =)

@bruAristimunha bruAristimunha merged commit 43c2caf into braindecode:master Sep 27, 2023
17 checks passed
@robintibor
Copy link
Contributor

I noticed the default valid accuracy callback now causes me quite some issues in writing examples, things are logged twice etc. Was there a specific reason this was needed? @PierreGtch Considering to undo this part (not the cross entropy loss default).

@PierreGtch
Copy link
Collaborator Author

@robintibor I just thought it made sense to log the accuracy by default for classifiers.
If it helps, see how I deactivated it in the plot_sleep_staging_usleep.py example: https://github.com/braindecode/braindecode/pull/541/files#diff-6fce3d4fb0b5aed7465d731b19bbf3ff2a3016d32e1d6e58d006fb5bf67a3b74
Otherwise, if it creates too many issues, we can remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default loss function Log accuracy score in EEGClassifier
3 participants