Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add new model: EEG-SimpleConv #581

Merged
merged 25 commits into from
Apr 3, 2024
Merged

Conversation

elouayas
Copy link
Contributor

@elouayas elouayas commented Mar 28, 2024

Adding the EEG-SimpleConv net.

  EEG-SimpleConv starts with a 1D convolutional layer, where each EEG channel
    enters a separate 1D convolutional channel. This is followed by a series of
    blocks of two 1D convolutional layers. Between the two convolutional layers
    of each block is a max pooling layer, which downsamples the data by a factor
    of 2. Each convolution is followed by a batch normalisation layer and a ReLU
    activation function. Finally, a global average pooling (in the time domain)
    is performed to obtain a single value per feature map, which is then fed
    into a linear layer to obtain the final classification prediction output.

braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #581 (5a0cc21) into master (7c15663) will decrease coverage by 0.07%.
The diff coverage is 83.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   84.06%   84.00%   -0.07%     
==========================================
  Files          65       66       +1     
  Lines        5227     5338     +111     
==========================================
+ Hits         4394     4484      +90     
- Misses        833      854      +21     

@bruAristimunha
Copy link
Collaborator

Don't forget to solve the comment when you solved the points ;) @elouayas

@elouayas
Copy link
Contributor Author

Don't forget to solve the comment when you solved the points ;) @elouayas

I just pushed, a version including all your comments :) !

@bruAristimunha bruAristimunha changed the title Add new model: EEG-SimpleConv [ENH] Add new model: EEG-SimpleConv Apr 2, 2024
@bruAristimunha
Copy link
Collaborator

Hi Alex, @agramfort!

Can you take a quickly look?

braindecode/models/eegsimpleconv.py Outdated Show resolved Hide resolved
braindecode/models/functions.py Show resolved Hide resolved
test/unit_tests/models/test_modules.py Show resolved Hide resolved
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
@bruAristimunha
Copy link
Collaborator

The green button is your @agramfort

@agramfort agramfort merged commit c8d7de6 into braindecode:master Apr 3, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants