Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing EEGWindowsDataset #607

Merged

Conversation

PierreGtch
Copy link
Collaborator

This PR:

  1. Exposes the use_mne_epochs parameter of create_windows_from_events
  2. warns when preprocessing an EEGWindowsDataset because the preprocessing steps will be applied on the raw data, not on epochs

Adding a use_mne_epochs parameter to create_fixed_length_windows and create_windows_from_target_channels would be desirable but more complicated.

Closes #605

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (f484011) to head (93fe508).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   86.86%   86.93%   +0.07%     
==========================================
  Files          65       65              
  Lines        5787     5796       +9     
==========================================
+ Hits         5027     5039      +12     
+ Misses        760      757       -3     

@bruAristimunha
Copy link
Collaborator

For me it's almost good @PierreGtch, just a few more tests to increase coverage and maybe a test for the function's behavior.

@PierreGtch
Copy link
Collaborator Author

@bruAristimunha Done :)

@bruAristimunha bruAristimunha merged commit 2dd005a into braindecode:master May 10, 2024
18 checks passed
@bruAristimunha
Copy link
Collaborator

Lgtm @PierreGtch, thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocessing on EEGWindowsDataset vs WindowsDataset
2 participants